From: "André Draszik" <andre.draszik@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [bug report] regulator: s2mps11: add S2MPG10 regulator
Date: Mon, 09 Feb 2026 14:07:35 +0000 [thread overview]
Message-ID: <13e12c2bf5e5396e3971137e4ab74e15b38d4b78.camel@linaro.org> (raw)
In-Reply-To: <aYmsu8qREppwBESH@stanley.mountain>
Hi Dan,
On Mon, 2026-02-09 at 12:45 +0300, Dan Carpenter wrote:
> [ Smatch checking is paused while we raise funding. #SadFace
> https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
>
> Hello André Draszik,
>
> Commit a2b8b9f33ce3 ("regulator: s2mps11: add S2MPG10 regulator")
> from Jan 22, 2026 (linux-next), leads to the following Smatch static
> checker warning:
>
> drivers/regulator/s2mps11.c:483 s2mpg10_of_parse_cb()
> warn: off by one 'ext_control' == ARRAY_SIZE()?
>
> drivers/regulator/s2mps11.c
> 458 if (of_property_read_u32(np, "samsung,ext-control", &ext_control))
> 459 return 0;
> 460
> 461 switch (s2mps11->dev_type) {
> 462 case S2MPG10:
> 463 switch (desc->id) {
> 464 case S2MPG10_BUCK1 ... S2MPG10_BUCK7:
> 465 case S2MPG10_BUCK10:
> 466 case S2MPG10_LDO3 ... S2MPG10_LDO19:
> 467 if (ext_control > S2MPG10_EXTCTRL_TCXO_ON2)
> 468 return -EINVAL;
> 469 break;
> 470
> 471 case S2MPG10_LDO20:
> 472 if (ext_control < S2MPG10_EXTCTRL_LDO20M_EN2 ||
> 473 ext_control > S2MPG10_EXTCTRL_LDO20M_EN)
> 474 return -EINVAL;
> 475 break;
> 476
> 477 default:
> 478 return -EINVAL;
> 479 }
> 480
> 481 if (ext_control > ARRAY_SIZE(ext_control_s2mpg10))
>
> This should be >= ARRAY_SIZE(). Although the earlier checks prevent an
> out of bounds access, it's still worth fixing the sanity check.
Thanks, yes. Although this was on purpose to avoid duplicated checks. I'd say
this test could be removed altogether as it's just confusing and useless.
Cheers,
Andre'
prev parent reply other threads:[~2026-02-09 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
2026-02-09 9:45 ` [bug report] regulator: s2mps11: add S2MPG10 regulator Dan Carpenter
2026-02-09 14:07 ` André Draszik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13e12c2bf5e5396e3971137e4ab74e15b38d4b78.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).