From: Youngmin Nam <youngmin.nam@samsung.com>
To: krzk@kernel.org, s.nawrocki@samsung.com, alim.akhtar@samsung.com,
linus.walleij@linaro.org, peter.griffin@linaro.org,
semen.protsenko@linaro.org, ivo.ivanov.ivanov1@gmail.com
Cc: ryu.real@samsung.com, d7271.choe@samsung.com,
shin.son@samsung.com, jaewon02.kim@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Youngmin Nam <youngmin.nam@samsung.com>
Subject: [PATCH v3 0/5] pinctrl: samsung: exynos9 cleanups and fixes
Date: Tue, 2 Dec 2025 18:36:07 +0900 [thread overview]
Message-ID: <20251202093613.852109-1-youngmin.nam@samsung.com> (raw)
In-Reply-To: CGME20251202093024epcas2p1567dddf09e3599867e9dc14a9a234d38@epcas2p1.samsung.com
Several SoCs carried near-duplicate pin bank macro families, making
tables verbose and hard to share when only the bank type (alive/off)
differs.
GS101 had its own helpers even though the newer EXYNOS9_* helpers cover
the same semantics, including per-bank filter control (FLTCON) offsets.
Some pin-bank tables didn't match the SoC TRMs (bank type, EINT class,
or bank names), and FLTCON wasn't always at a contiguous offset from
EINT.
This series does
- Consolidate on EXYNOS9_* pin-bank macros. Pass bank_type explicitly.
- Fix table errors on Exynos2200/7885/8890/8895 per TRM.
- Add explicit per-bank FLTCON offsets and update affected tables.
- Drop GS101-specific macros in favor of EXYNOS9_*.
- Rename gs101_pinctrl_{suspend,resume} ->
exynos9_pinctrl_{suspend,resume}.
This series was based on the pinctrl/samsung tree [1].
I tested on Exynos850 through boot and verified the pin values as
follows:
$:/sys/kernel/debug/pinctrl/139b0000.pinctrl-samsung-pinctrl# cat pins
registered pins: 42
pin 0 (gpg0-0) 0:gpg0 CON(0x0) DAT(0x0) PUD(0x1) DRV(0x2) CON_PDN(0x2) PUD_PDN(0x1)
pin 1 (gpg0-1) 1:gpg0 CON(0x0) DAT(0x0) PUD(0x1) DRV(0x2) CON_PDN(0x2) PUD_PDN(0x1)
...
Additional testing on the affected Exynos9-era platforms would be
appreciated.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git
Changes in v2:
- Added base tree for this series (pinctrl/samsung).
- Renamed the macro parameter from 'types' to 'bank_type' for clarity
(struct member remains 'type').
- Reflowed commit messages (wrap at ~72 cols).
- Replaced non-ASCII characters with ASCII equivalents.
- Collected tags:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Tested-by: Sam Protsenko <semen.protsenko@linaro.org>
- Normalized hex literals to lowercase and removed double spaces.
- Aligned backslashes in macro definitions to form a vertical column
for readability.
- Added missing mailing lists (including linux-kernel) to Cc per
scripts/get_maintainer.pl.
Changes in v3:
- Collected tags:
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: Peter Griffin <peter.griffin@linaro.org> (tested on Pixel6/gs101)
Youngmin Nam (5):
pinctrl: samsung: Consolidate pin-bank macros under EXYNOS9_* and pass
bank_type explicitly
pinctrl: samsung: fix incorrect pin-bank entries on
Exynos2200/7885/8890/8895
pinctrl: samsung: add per-bank FLTCON offset to EXYNOS9_PIN_BANK_* and
fix tables
pinctrl: samsung: fold GS101 pin-bank macros into EXYNOS9_*
pinctrl: samsung: rename gs101_pinctrl_* to exynos9_pinctrl_*
.../pinctrl/samsung/pinctrl-exynos-arm64.c | 1069 ++++++++---------
drivers/pinctrl/samsung/pinctrl-exynos.c | 4 +-
drivers/pinctrl/samsung/pinctrl-exynos.h | 97 +-
drivers/pinctrl/samsung/pinctrl-samsung.h | 4 +-
4 files changed, 562 insertions(+), 612 deletions(-)
--
2.52.0
next parent reply other threads:[~2025-12-02 9:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251202093024epcas2p1567dddf09e3599867e9dc14a9a234d38@epcas2p1.samsung.com>
2025-12-02 9:36 ` Youngmin Nam [this message]
2025-12-02 9:36 ` [PATCH v3 1/5] pinctrl: samsung: Consolidate pin-bank macros under EXYNOS9_* and pass bank_type explicitly Youngmin Nam
2025-12-17 4:28 ` Alim Akhtar
2025-12-28 11:40 ` Krzysztof Kozlowski
2025-12-02 9:36 ` [PATCH v3 2/5] pinctrl: samsung: fix incorrect pin-bank entries on Exynos2200/7885/8890/8895 Youngmin Nam
2025-12-17 4:33 ` Alim Akhtar
2025-12-28 11:37 ` Krzysztof Kozlowski
2026-03-06 21:17 ` Peter Griffin
2025-12-02 9:36 ` [PATCH v3 3/5] pinctrl: samsung: add per-bank FLTCON offset to EXYNOS9_PIN_BANK_* and fix tables Youngmin Nam
2025-12-17 4:46 ` Alim Akhtar
2025-12-28 11:41 ` Krzysztof Kozlowski
2026-03-06 21:55 ` Peter Griffin
2025-12-02 9:36 ` [PATCH v3 4/5] pinctrl: samsung: fold GS101 pin-bank macros into EXYNOS9_* Youngmin Nam
2025-12-17 4:43 ` Alim Akhtar
2025-12-02 9:36 ` [PATCH v3 5/5] pinctrl: samsung: rename gs101_pinctrl_* to exynos9_pinctrl_* Youngmin Nam
2025-12-17 4:53 ` Alim Akhtar
2025-12-28 11:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202093613.852109-1-youngmin.nam@samsung.com \
--to=youngmin.nam@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=d7271.choe@samsung.com \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=jaewon02.kim@samsung.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=ryu.real@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=shin.son@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).