From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Miguel Ojeda <ojeda@kernel.org>, Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Russell King <linux@armlinux.org.uk>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Nipun Gupta <nipun.gupta@amd.com>,
Nikhil Agarwal <nikhil.agarwal@amd.com>,
Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Vinod Koul <vkoul@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
dmaengine@vger.kernel.org, linux-media@vger.kernel.org,
linux-pm@vger.kernel.org,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Frank Li <Frank.Li@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: [PATCH v3 09/12] clk: imx: imx31: Simplify with scoped for each OF child loop
Date: Fri, 09 Jan 2026 17:57:53 +0100 [thread overview]
Message-ID: <20260109-of-for-each-compatible-scoped-v3-9-c22fa2c0749a@oss.qualcomm.com> (raw)
In-Reply-To: <20260109-of-for-each-compatible-scoped-v3-0-c22fa2c0749a@oss.qualcomm.com>
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Acked-by: Abel Vesa <abelvesa@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Depends on first patch.
---
drivers/clk/imx/clk-imx31.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/imx/clk-imx31.c b/drivers/clk/imx/clk-imx31.c
index 4c8d9ff0b2ad..962eccac63ce 100644
--- a/drivers/clk/imx/clk-imx31.c
+++ b/drivers/clk/imx/clk-imx31.c
@@ -123,18 +123,15 @@ static void __init _mx31_clocks_init(void __iomem *base, unsigned long fref)
static void __init mx31_clocks_init_dt(struct device_node *np)
{
- struct device_node *osc_np;
u32 fref = 26000000; /* default */
void __iomem *ccm;
- for_each_compatible_node(osc_np, NULL, "fixed-clock") {
+ for_each_compatible_node_scoped(osc_np, NULL, "fixed-clock") {
if (!of_device_is_compatible(osc_np, "fsl,imx-osc26m"))
continue;
- if (!of_property_read_u32(osc_np, "clock-frequency", &fref)) {
- of_node_put(osc_np);
+ if (!of_property_read_u32(osc_np, "clock-frequency", &fref))
break;
- }
}
ccm = of_iomap(np, 0);
--
2.51.0
next prev parent reply other threads:[~2026-01-09 16:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 16:57 [PATCH v3 00/12] of/treewide: Simplify with for_each_compatible_node_scoped() Krzysztof Kozlowski
2026-01-09 16:57 ` [PATCH v3 01/12] of: Add for_each_compatible_node_scoped() helper Krzysztof Kozlowski
2026-01-09 16:57 ` [PATCH v3 02/12] ARM: at91: Simplify with scoped for each OF child loop Krzysztof Kozlowski
2026-01-10 15:09 ` Claudiu Beznea
2026-01-09 16:57 ` [PATCH v3 03/12] ARM: exynos: " Krzysztof Kozlowski
2026-01-09 16:57 ` [PATCH v3 04/12] powerpc/fsp2: " Krzysztof Kozlowski
2026-01-09 17:21 ` Christophe Leroy (CS GROUP)
2026-01-09 16:57 ` [PATCH v3 05/12] powerpc/wii: " Krzysztof Kozlowski
2026-01-09 17:22 ` Christophe Leroy (CS GROUP)
2026-01-09 16:57 ` [PATCH v3 06/12] cdx: " Krzysztof Kozlowski
2026-01-12 12:48 ` Jonathan Cameron
2026-01-09 16:57 ` [PATCH v3 07/12] cdx: Use mutex guard to simplify error handling Krzysztof Kozlowski
2026-01-12 12:48 ` Jonathan Cameron
2026-01-09 16:57 ` [PATCH v3 08/12] clk: imx: imx27: Simplify with scoped for each OF child loop Krzysztof Kozlowski
2026-01-09 16:57 ` Krzysztof Kozlowski [this message]
2026-01-09 16:57 ` [PATCH v3 10/12] dmaengine: fsl_raid: " Krzysztof Kozlowski
2026-01-09 16:57 ` [PATCH v3 11/12] cpufreq: s5pv210: " Krzysztof Kozlowski
2026-01-09 16:57 ` [PATCH v3 12/12] media: samsung: exynos4-is: " Krzysztof Kozlowski
2026-01-29 17:14 ` [PATCH v3 00/12] of/treewide: Simplify with for_each_compatible_node_scoped() Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109-of-for-each-compatible-scoped-v3-9-c22fa2c0749a@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=Frank.Li@nxp.com \
--cc=abelvesa@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alim.akhtar@samsung.com \
--cc=chleroy@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jonathan.cameron@huawei.com \
--cc=justinstitt@google.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=mchehab@kernel.org \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=peng.fan@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).