From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Juan Yescas" <jyescas@google.com>,
"Will McVicker" <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"André Draszik" <andre.draszik@linaro.org>
Subject: [PATCH v4 10/10] pmdomain: samsung: implement domain-supply regulator
Date: Wed, 28 Jan 2026 16:10:59 +0000 [thread overview]
Message-ID: <20260128-gs101-pd-v4-10-cbe7bd5a4060@linaro.org> (raw)
In-Reply-To: <20260128-gs101-pd-v4-0-cbe7bd5a4060@linaro.org>
Some power domains on Exynos are fed by a regulator rail and therefore
regulator control needs be implemented for Exynos power domains.
On Google gs101, HSI0 (USB) is one example of such a power domain.
While at it, add a to_exynos_pd() to avoid direct use of
container_of() in various additional places, and update existing code
to use it.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
drivers/pmdomain/samsung/exynos-pm-domains.c | 53 +++++++++++++++++++++++++---
1 file changed, 48 insertions(+), 5 deletions(-)
diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c
index f59986b56213dfcc470d9cccc61a36a81954bdcc..ed7a5807555bcf86e4ec88166bfd5f6c06c9322c 100644
--- a/drivers/pmdomain/samsung/exynos-pm-domains.c
+++ b/drivers/pmdomain/samsung/exynos-pm-domains.c
@@ -20,12 +20,15 @@
#include <linux/of_address.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
#define EXYNOS_SMC_CMD_PREPARE_PD_ONOFF 0x82000410
#define EXYNOS_GET_IN_PD_DOWN 0
#define EXYNOS_WAKEUP_PD_DOWN 1
#define EXYNOS_RUNTIME_PM_TZPC_GROUP 2
+#define to_exynos_pd(gpd) container_of_const(gpd, struct exynos_pm_domain, pd)
+
struct exynos_pm_domain_config {
/* Value for LOCAL_PWR_CFG and STATUS fields for each domain */
u32 local_pwr_cfg;
@@ -39,6 +42,7 @@ struct exynos_pm_domain_config {
struct exynos_pm_domain {
struct regmap *regmap;
struct device *dev;
+ struct regulator *supply;
struct generic_pm_domain pd;
const struct exynos_pm_domain_config *cfg;
u32 configuration_reg;
@@ -64,12 +68,10 @@ static int exynos_pd_access_controller_power(struct exynos_pm_domain *pd,
static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on)
{
- struct exynos_pm_domain *pd;
+ struct exynos_pm_domain *pd = to_exynos_pd(domain);
u32 timeout, pwr;
int err;
- pd = container_of(domain, struct exynos_pm_domain, pd);
-
if (!power_on) {
err = exynos_pd_access_controller_power(pd, power_on);
if (err) {
@@ -126,14 +128,45 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on)
return err;
}
+static int exynos_pd_regulator_enable(struct regulator *supply)
+{
+ return supply ? regulator_enable(supply) : 0;
+}
+
+static int exynos_pd_regulator_disable(struct regulator *supply)
+{
+ return supply ? regulator_disable(supply) : 0;
+}
+
static int exynos_pd_power_on(struct generic_pm_domain *domain)
{
- return exynos_pd_power(domain, true);
+ struct exynos_pm_domain *pd = to_exynos_pd(domain);
+ int ret;
+
+ ret = exynos_pd_regulator_enable(pd->supply);
+ if (ret)
+ return ret;
+
+ ret = exynos_pd_power(domain, true);
+ if (ret)
+ exynos_pd_regulator_disable(pd->supply);
+
+ return ret;
}
static int exynos_pd_power_off(struct generic_pm_domain *domain)
{
- return exynos_pd_power(domain, false);
+ struct exynos_pm_domain *pd = to_exynos_pd(domain);
+ int ret;
+
+ ret = exynos_pd_power(domain, false);
+ if (ret)
+ return ret;
+
+ /* Ignore regulator errors - the domain was disabled after all. */
+ exynos_pd_regulator_disable(pd->supply);
+
+ return 0;
}
static const struct exynos_pm_domain_config exynos4210_cfg = {
@@ -283,6 +316,16 @@ static int exynos_pd_probe(struct platform_device *pdev)
if (ret)
return ret;
+ /* get the domain power supply if required */
+ pd->supply = devm_regulator_get_optional(dev, "domain");
+ if (IS_ERR(pd->supply)) {
+ if (PTR_ERR(pd->supply) != -ENODEV)
+ return dev_err_probe(dev, PTR_ERR(pd->supply),
+ "failed to get domain supply");
+
+ pd->supply = NULL;
+ }
+
/*
* Some Samsung platforms with bootloaders turning on the splash-screen
* and handing it over to the kernel, requires the power-domains to be
--
2.52.0.457.g6b5491de43-goog
next prev parent reply other threads:[~2026-01-28 16:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 16:10 [PATCH v4 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-01-28 16:10 ` [PATCH v4 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-01-29 16:55 ` Rob Herring
2026-01-30 5:40 ` André Draszik
2026-01-28 16:10 ` [PATCH v4 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-01-28 16:10 ` [PATCH v4 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-01-28 16:10 ` [PATCH v4 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-01-28 16:10 ` [PATCH v4 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-01-28 16:10 ` [PATCH v4 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-01-28 16:10 ` [PATCH v4 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-01-28 16:10 ` [PATCH v4 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-01-28 16:10 ` [PATCH v4 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-01-28 16:10 ` André Draszik [this message]
2026-01-29 7:53 ` [PATCH v4 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-01-28 18:53 ` [PATCH v4 00/10] pmdomain: samsung: add support for Google GS101 Krzysztof Kozlowski
2026-02-05 12:05 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128-gs101-pd-v4-10-cbe7bd5a4060@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).