From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Brian Masney <bmasney@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 11/12] clk: samsung: acpm: drop determine_rate op and use CLK_ROUNDING_NOOP flag
Date: Wed, 11 Mar 2026 13:52:27 +0200 [thread overview]
Message-ID: <30142b6f-4578-4472-bbbb-2574f1c0288a@linaro.org> (raw)
In-Reply-To: <20260309-clk-det-rate-fw-managed-v2-11-c48ef5a3100a@redhat.com>
On 3/9/26 4:38 PM, Brian Masney wrote:
> This clk driver has a noop determine_rate clk op. Drop this empty
> function, and enable the CLK_ROUNDING_NOOP flag.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> To: Tudor Ambarus <tudor.ambarus@linaro.org>
> To: Krzysztof Kozlowski <krzk@kernel.org>
> To: Sylwester Nawrocki <s.nawrocki@samsung.com>
> To: Chanwoo Choi <cw00.choi@samsung.com>
> To: Michael Turquette <mturquette@baylibre.com>
> To: Stephen Boyd <sboyd@kernel.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> ---
> drivers/clk/samsung/clk-acpm.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-acpm.c b/drivers/clk/samsung/clk-acpm.c
> index b90809ce3f882c489114c9d7299417d7fe373749..b79d973eaa0c275c508a51926ecde5349f00feba 100644
> --- a/drivers/clk/samsung/clk-acpm.c
> +++ b/drivers/clk/samsung/clk-acpm.c
> @@ -72,18 +72,6 @@ static unsigned long acpm_clk_recalc_rate(struct clk_hw *hw,
> clk->mbox_chan_id, clk->id);
> }
>
> -static int acpm_clk_determine_rate(struct clk_hw *hw,
> - struct clk_rate_request *req)
> -{
> - /*
> - * We can't figure out what rate it will be, so just return the
> - * rate back to the caller. acpm_clk_recalc_rate() will be called
> - * after the rate is set and we'll know what rate the clock is
> - * running at then.
> - */
> - return 0;
> -}
> -
> static int acpm_clk_set_rate(struct clk_hw *hw, unsigned long rate,
> unsigned long parent_rate)
> {
> @@ -95,7 +83,6 @@ static int acpm_clk_set_rate(struct clk_hw *hw, unsigned long rate,
>
> static const struct clk_ops acpm_clk_ops = {
> .recalc_rate = acpm_clk_recalc_rate,
> - .determine_rate = acpm_clk_determine_rate,
> .set_rate = acpm_clk_set_rate,
> };
>
> @@ -106,6 +93,7 @@ static int acpm_clk_register(struct device *dev, struct acpm_clk *aclk,
>
> init.name = name;
> init.ops = &acpm_clk_ops;
> + init.flags = CLK_ROUNDING_NOOP;
> aclk->hw.init = &init;
>
> return devm_clk_hw_register(dev, &aclk->hw);
>
next prev parent reply other threads:[~2026-03-11 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:38 [PATCH v2 00/12] clk: add new flag CLK_ROUNDING_NOOP Brian Masney
2026-03-09 14:38 ` [PATCH v2 01/12] " Brian Masney
2026-04-29 2:15 ` Stephen Boyd
2026-04-29 13:55 ` Brian Masney
2026-03-09 14:38 ` [PATCH v2 11/12] clk: samsung: acpm: drop determine_rate op and use CLK_ROUNDING_NOOP flag Brian Masney
2026-03-11 11:52 ` Tudor Ambarus [this message]
2026-03-11 11:50 ` [PATCH v2 00/12] clk: add new flag CLK_ROUNDING_NOOP Tudor Ambarus
2026-03-11 13:01 ` Brian Masney
2026-04-28 20:38 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30142b6f-4578-4472-bbbb-2574f1c0288a@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=bmasney@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).