From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pritam Manohar Sutar <pritam.sutar@samsung.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
alim.akhtar@samsung.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
rosa.pila@samsung.com, dev.tailor@samsung.com,
faraz.ata@samsung.com, muhammed.ali@samsung.com,
selvarasu.g@samsung.com
Subject: Re: [PATCH v2 2/3] arm64: dts: exynos: ExynosAutov920: Add regulators for the USB
Date: Thu, 22 Jan 2026 14:34:14 +0100 [thread overview]
Message-ID: <352427f4-144a-4a43-a2f3-dd959302939f@kernel.org> (raw)
In-Reply-To: <20260122130721.205664-3-pritam.sutar@samsung.com>
On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> Add dummy regulator for USB and PHY supplies.
>
> Add vbus regulator that is enabled by GPIO pin.
>
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
> .../boot/dts/exynos/exynosautov920-sadk.dts | 139 ++++++++++++++++++
> 1 file changed, 139 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index a397f068ed53..f90f7704597c 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -52,6 +52,76 @@ memory@80000000 {
> <0x8 0x80000000 0x1 0xfba00000>,
> <0xa 0x00000000 0x2 0x00000000>;
> };
> +
> + /* TODO: Remove this once PMIC is implemented */
> + dummy_regulator: regulator-0 {
> + compatible = "regulator-fixed";
> + regulator-name = "dummy_regulator";
> + };
> +
> + usbdrd31_dwc3_vbus: usbdrd31_dwc3-vbus {
Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
None of the regulators are called like you wrote. Really NONE.
Also, carefully follow DTS coding style.
> + compatible = "regulator-fixed";
> + regulator-name = "usbdrd31_dwc3-vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + enable-active-high;
> + regulator-always-on;
> + gpio = <&gpp2 0 GPIO_ACTIVE_HIGH>;
> + };
> +
> + /* Use gpio for enabling vbus regulator */
> + usb_phy0: usb-phy0 {
usb-phy-0
> + compatible = "usb-nop-xceiv";
> + vbus-supply = <&usbdrd31_dwc3_vbus>;
That's pretty incomplete. Why do you need such node - just to toggle
regulator?
> + };
...
> +&usbdrd20_phy2 {
> + dvdd-supply = <&dummy_regulator>;
> + vdd18-supply = <&dummy_regulator>;
> + vdd33-supply = <&dummy_regulator>;
> +};
> +
> +&usbdrd20_dwc3_2 {
> + maximum-speed = "high-speed";
> + usb-phy = <&usb_phy3>;
> +};
> +
> +&usbdrd20_2 {
> + vdd10-supply = <&dummy_regulator>;
> + vdd33-supply = <&dummy_regulator>;
> +};
That's a bit too much of dummies. This is heavily incomplete. You need
to bring back the PMIC first.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-22 13:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260122125130epcas5p4ac37f540c609f3016ff02f5708e897a2@epcas5p4.samsung.com>
2026-01-22 13:07 ` [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC Pritam Manohar Sutar
2026-01-22 13:07 ` [PATCH v2 1/3] arm64: dts: exynos: ExynosAutov920: Add USB and USB-phy nodes Pritam Manohar Sutar
2026-01-22 13:07 ` [PATCH v2 2/3] arm64: dts: exynos: ExynosAutov920: Add regulators for the USB Pritam Manohar Sutar
2026-01-22 13:34 ` Krzysztof Kozlowski [this message]
2026-02-12 11:37 ` pritam.sutar
2026-02-15 8:57 ` Krzysztof Kozlowski
2026-02-18 9:28 ` pritam.sutar
2026-02-18 19:54 ` Krzysztof Kozlowski
2026-03-04 7:46 ` pritam.sutar
2026-03-04 8:08 ` Krzysztof Kozlowski
2026-01-22 13:07 ` [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes Pritam Manohar Sutar
2026-01-22 13:35 ` Krzysztof Kozlowski
2026-01-23 7:29 ` Pritam Manohar Sutar
2026-01-23 7:59 ` Pritam Manohar Sutar
2026-01-23 8:05 ` Krzysztof Kozlowski
2026-02-12 11:40 ` pritam.sutar
2026-01-28 7:36 ` Krzysztof Kozlowski
2026-02-12 11:42 ` pritam.sutar
2026-01-22 17:15 ` [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC Rob Herring
2026-01-23 6:23 ` Pritam Manohar Sutar
2026-01-23 7:31 ` Krzysztof Kozlowski
2026-02-12 11:48 ` pritam.sutar
2026-01-28 7:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=352427f4-144a-4a43-a2f3-dd959302939f@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=muhammed.ali@samsung.com \
--cc=pritam.sutar@samsung.com \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=selvarasu.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).