From: Ulf Hansson <ulf.hansson@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Juan Yescas <jyescas@google.com>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v4 00/10] pmdomain: samsung: add support for Google GS101
Date: Thu, 5 Feb 2026 13:05:44 +0100 [thread overview]
Message-ID: <CAPDyKFoRXaiZiZw0NmmgnJzfw3sCYi1cNAuLHUU6fyF-4gxDuA@mail.gmail.com> (raw)
In-Reply-To: <20260128-gs101-pd-v4-0-cbe7bd5a4060@linaro.org>
On Wed, 28 Jan 2026 at 17:10, André Draszik <andre.draszik@linaro.org> wrote:
>
> Hi,
>
> This series adds support for the power domains on Google GS101.
>
> There are a few differences compared to SoCs already supported by this
> driver:
> * register access does not work via plain ioremap() / readl() /
> writel().
> Instead, the regmap created by the PMU driver must be used (which
> uses Arm SMCC calls under the hood).
> * DTZPC: a call needs to be made before and after power domain off/on,
> to inform the EL3 firmware of the request.
> * power domains can and are fed by a regulator rail and therefore
> regulator control needed be implemented.
>
> Bullet points 2 and 3 are new compared to previous versions of this
> series, and related changes are in patches 1, 2, 9, and 10. I can merge
> patch 9 (SMC call) into the gs101 patch (patch 7) if preferred, but for
> now I kept them independent to make it easier to see changes compared
> to previous versions of this series, and because patch 8 actually
> applies to not only gs101, but to many newer Exynos SoCs, and to make
> the two patches themselves easier to review and reason about.
>
> The DT update to add the new required properties on gs101 will be
> posted separately.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Changes in v4:
> - drop unneeded or already merged patches
> - drop patch "pmdomain: samsung: convert to regmap_read_poll_timeout()"
> as Marek reported issues on some platforms
> - rebase
> - DTZPC related changes
> - Link to v3: https://lore.kernel.org/r/20251016-gs101-pd-v3-0-7b30797396e7@linaro.org
>
> Changes in v3:
> - use additionalProperties, not unevaluatedProperties in patch 2
> - fix path in $id in patch 2 (Rob)
> - drop comment around 'select' in patch 2 (Rob)
> - collect tags
> - Link to v2: https://lore.kernel.org/r/20251009-gs101-pd-v2-0-3f4a6db2af39@linaro.org
>
> Changes in v2:
> - Krzysztof:
> - move google,gs101-pmu binding into separate file
> - mark devm_kstrdup_const() patch as fix
> - use bool for need_early_sync_state
> - merge patches 8 and 10 from v1 series into one patch
> - collect tags
> - Link to v1: https://lore.kernel.org/r/20251006-gs101-pd-v1-0-f0cb0c01ea7b@linaro.org
>
> ---
> André Draszik (10):
> dt-bindings: soc: google: add google,gs101-dtzpc
> dt-bindings: power: samsung: add google,gs101-pd
> dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding
> dt-bindings: soc: google: gs101-pmu: allow power domains as children
> pmdomain: samsung: convert to using regmap
> pmdomain: samsung: don't hard-code offset for registers to 0 and 4
> pmdomain: samsung: add support for google,gs101-pd
> pmdomain: samsung: use dev_err() instead of pr_err()
> pmdomain: samsung: implement SMC to save / restore TZ config
> pmdomain: samsung: implement domain-supply regulator
>
> .../devicetree/bindings/power/pd-samsung.yaml | 29 ++-
> .../bindings/soc/google/google,gs101-dtzpc.yaml | 42 ++++
> .../bindings/soc/google/google,gs101-pmu.yaml | 97 ++++++++
> .../bindings/soc/samsung/exynos-pmu.yaml | 20 --
> MAINTAINERS | 2 +
> drivers/pmdomain/samsung/exynos-pm-domains.c | 254 ++++++++++++++++++---
> 6 files changed, 395 insertions(+), 49 deletions(-)
> ---
> base-commit: e3b32dcb9f23e3c3927ef3eec6a5842a988fb574
> change-id: 20251001-gs101-pd-d4dc97d70a84
>
> Best regards,
> --
> André Draszik <andre.draszik@linaro.org>
>
I have looked through the series and it looks good to me. I will be
awaiting a new version and to get the DT patches acked, before I
continue to apply patches.
Kind regards
Uffe
prev parent reply other threads:[~2026-02-05 12:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 16:10 [PATCH v4 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-01-28 16:10 ` [PATCH v4 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-01-29 16:55 ` Rob Herring
2026-01-30 5:40 ` André Draszik
2026-01-28 16:10 ` [PATCH v4 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-01-28 16:10 ` [PATCH v4 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-01-28 16:10 ` [PATCH v4 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-01-28 16:10 ` [PATCH v4 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-01-28 16:10 ` [PATCH v4 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-01-28 16:10 ` [PATCH v4 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-01-28 16:10 ` [PATCH v4 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-01-28 16:10 ` [PATCH v4 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-01-28 16:10 ` [PATCH v4 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-01-29 7:53 ` André Draszik
2026-01-28 18:53 ` [PATCH v4 00/10] pmdomain: samsung: add support for Google GS101 Krzysztof Kozlowski
2026-02-05 12:05 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoRXaiZiZw0NmmgnJzfw3sCYi1cNAuLHUU6fyF-4gxDuA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).