From: Damon Ding <damon.ding@rock-chips.com>
To: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, luca.ceresoli@bootlin.com
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com,
p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de,
andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com,
dianders@chromium.org, m.szyprowski@samsung.com,
jani.nikula@intel.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v9 00/15] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver
Date: Thu, 26 Feb 2026 14:54:41 +0800 [thread overview]
Message-ID: <e3230ebc-6e2b-4498-a1e6-f0df981e31c4@rock-chips.com> (raw)
In-Reply-To: <20260210071225.2566099-1-damon.ding@rock-chips.com>
On 2/10/2026 3:12 PM, Damon Ding wrote:
> Picked from:
> https://lore.kernel.org/all/20251217093321.3108939-1-damon.ding@rock-chips.com/
>
> PATCH 1 is to add a new parameter to store the point of next bridge.
> PATCH 2 is to make legacy bridge driver more universal.
> PATCH 3-8 are preparations for apply drm_bridge_connector helper.
> PATCH 9 is to apply the drm_bridge_connector helper.
> PATCH 10-12 are to move the panel/bridge parsing to the Analogix side.
> PATCH 13 is to attach the next bridge on Analogix side uniformly.
> PATCH 14-15 are to apply the panel_bridge helper.
>
> The following reviewed commits, which to make codes more concise, are
> rebased to the front of this patch series:
>
> https://lore.kernel.org/all/20251110085823.1197472-1-damon.ding@rock-chips.com/
> https://lore.kernel.org/all/20251111022103.1350183-1-damon.ding@rock-chips.com/
>
> Damon Ding (15):
> drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge
> drm/bridge: Move legacy bridge driver out of imx directory for
> multi-platform use
> drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge
> drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector
> drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the
> display-timings node
> drm/bridge: analogix_dp: Remove redundant
> &analogix_dp_plat_data.skip_connector
> drm/bridge: analogix_dp: Move the color format check to
> .atomic_check() for Rockchip platforms
> drm/bridge: analogix_dp: Remove unused
> &analogix_dp_plat_data.get_modes()
> drm/bridge: analogix_dp: Apply drm_bridge_connector helper
> drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe()
> drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe()
> drm/exynos: exynos_dp: Apply analogix_dp_finish_probe()
> drm/bridge: analogix_dp: Attach the next bridge in
> analogix_dp_bridge_attach()
> drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing
> in analogix_dp_unbind()
> drm/bridge: analogix_dp: Apply panel_bridge helper
>
> drivers/gpu/drm/bridge/Kconfig | 10 +
> drivers/gpu/drm/bridge/Makefile | 1 +
> drivers/gpu/drm/bridge/analogix/Kconfig | 1 +
> .../drm/bridge/analogix/analogix_dp_core.c | 238 +++++++++---------
> .../drm/bridge/analogix/analogix_dp_core.h | 1 -
> drivers/gpu/drm/bridge/imx/Kconfig | 10 -
> drivers/gpu/drm/bridge/imx/Makefile | 1 -
> .../gpu/drm/bridge/imx/imx-legacy-bridge.c | 91 -------
> .../gpu/drm/bridge/of-display-mode-bridge.c | 93 +++++++
> drivers/gpu/drm/exynos/Kconfig | 2 +
> drivers/gpu/drm/exynos/exynos_dp.c | 110 ++------
> drivers/gpu/drm/imx/ipuv3/Kconfig | 4 +-
> drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 6 +-
> drivers/gpu/drm/imx/ipuv3/parallel-display.c | 5 +-
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 67 +----
> include/drm/bridge/analogix_dp.h | 8 +-
> include/drm/bridge/imx.h | 17 --
> include/drm/bridge/of-display-mode-bridge.h | 17 ++
> 19 files changed, 297 insertions(+), 386 deletions(-)
> delete mode 100644 drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
> create mode 100644 drivers/gpu/drm/bridge/of-display-mode-bridge.c
> delete mode 100644 include/drm/bridge/imx.h
> create mode 100644 include/drm/bridge/of-display-mode-bridge.h
>
> ---
>
> Changes in v2:
> - Update Exynos DP driver synchronously.
> - Move the panel/bridge parsing to the Analogix side.
>
> Changes in v3:
> - Rebase for the existing devm_drm_bridge_alloc() applying commit.
> - Fix the typographical error of panel/bridge check in exynos_dp_bind().
> - Squash all commits related to skip_connector deletion in both Exynos and
> Analogix code into one.
> - Apply panel_bridge helper to make the codes more concise.
> - Fix the handing of bridge in analogix_dp_bridge_get_modes().
> - Remove unnecessary parameter struct drm_connector* for callback
> &analogix_dp_plat_data.attach().
> - In order to decouple the connector driver and the bridge driver, move
> the bridge connector initilization to the Rockchip and Exynos sides.
>
> Changes in v4:
> - Rebase for the applied &drm_bridge_funcs.detect() modification commit.
> - Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe().
> - Drop the drmm_encoder_init() modification commit.
> - Rename the &analogix_dp_plat_data.bridge to
> &analogix_dp_plat_data.next_bridge.
>
> Changes in v5:
> - Add legacy bridge to parse the display-timings node under the dp node
> for Exynos side.
> - Move color format check to &drm_connector_helper_funcs.atomic_check()
> in order to get rid of &analogix_dp_plat_data.get_modes().
> - Remove unused callback &analogix_dp_plat_data.get_modes().
> - Distinguish the &drm_bridge->ops of Analogix bridge based on whether
> the downstream device is a panel, a bridge or neither.
> - Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP, and remove it for
> ROCKCHIP_ANALOGIX_DP.
> - Apply rockchip_dp_attach() to support the next bridge attachment for
> the Rockchip side.
> - Move next_bridge attachment from Analogix side to Rockchip/Exynos sides.
>
> Changes in v6:
> - Move legacy bridge driver out of imx directory for multi-platform use.
> - Apply DRM legacy bridge to parse display timings intead of implementing
> the same codes only for Exynos DP.
> - Ensure last bridge determines EDID/modes detection capabilities in DRM
> bridge_connector driver.
> - Remove unnecessary drm_bridge_get_modes() in
> analogix_dp_bridge_get_modes().
> - Simplify analogix_dp_bridge_edid_read().
> - If the next is a bridge, set DRM_BRIDGE_OP_DETECT and return
> connector_status_connected in analogix_dp_bridge_detect().
> - Set flag DRM_BRIDGE_ATTACH_NO_CONNECTOR for bridge attachment while
> binding. Meanwhile, make DRM_BRIDGE_ATTACH_NO_CONNECTOR unsuppported
> in analogix_dp_bridge_attach().
> - Move the next bridge attachment to the Analogix side rather than
> scattered on Rockchip and Exynos sides.
> - Remove the unnecessary analogix_dp_bridge_get_modes().
> - Squash [PATCH v5 15/17] into [PATCH v5 17/17].
> - Fix the &drm_bridge->ops to DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT.
>
> Changes in v7:
> - As Luca suggested, simplify the code and related comment for bridge_connector
> modifications. Additionally, move the commit related to bridge_connector to
> the top of this patch series.
> - Rename legacy-bridge driver to of-display-mode-bridge driver.
> - Remove unnecessary API drm_bridge_is_legacy() and apply a temporary flag
> &exynos_dp_device.has_of_bridge instead, which will be removed finally.
> - Remove exynos_dp_legacy_bridge_init() and inline API
> devm_drm_of_display_mode_bridge().
>
> Changes in v8:
> - Adapt the related modifications to the newest bridge_connector driver.
>
> Changes in v9:
> - Fix the Kconfig help text for CONFIG_DRM_OF_DISPLAY_MODE_BRIDGE.
> - Add Tested-by tag from Heiko.
>
Gentle ping.
I think the patches are in good shape and ready for merging.
Best regards,
Damon
prev parent reply other threads:[~2026-02-26 7:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 7:12 [PATCH v9 00/15] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-02-10 7:12 ` [PATCH v9 01/15] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2026-02-10 7:12 ` [PATCH v9 02/15] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-03-03 9:42 ` Luca Ceresoli
2026-02-10 7:12 ` [PATCH v9 03/15] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-02-10 7:12 ` [PATCH v9 04/15] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-02-10 7:12 ` [PATCH v9 05/15] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2026-03-03 9:42 ` Luca Ceresoli
2026-02-10 7:12 ` [PATCH v9 06/15] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2026-03-03 9:42 ` Luca Ceresoli
2026-02-10 7:12 ` [PATCH v9 07/15] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2026-02-10 7:12 ` [PATCH v9 08/15] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2026-03-03 9:42 ` Luca Ceresoli
2026-02-10 7:12 ` [PATCH v9 09/15] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2026-03-03 9:42 ` Luca Ceresoli
2026-03-09 11:25 ` Damon Ding
2026-03-09 13:34 ` Damon Ding
2026-02-10 7:12 ` [PATCH v9 10/15] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2026-03-03 9:54 ` Luca Ceresoli
2026-03-09 11:51 ` Damon Ding
2026-03-09 13:42 ` Damon Ding
2026-02-10 7:12 ` [PATCH v9 11/15] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2026-02-10 7:12 ` [PATCH v9 12/15] drm/exynos: exynos_dp: " Damon Ding
2026-02-10 7:12 ` [PATCH v9 13/15] drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Damon Ding
2026-02-10 9:10 ` [PATCH v9 14/15] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2026-02-10 9:10 ` [PATCH v9 15/15] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-02-26 6:54 ` Damon Ding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3230ebc-6e2b-4498-a1e6-f0df981e31c4@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=imx@lists.linux.dev \
--cc=inki.dae@samsung.com \
--cc=jani.nikula@intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=sw0312.kim@samsung.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).