From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Igor Pylypiv <ipylypiv@google.com>
Subject: Re: [PATCH] scsi: libsas: Fix declaration of ncq priority attributes
Date: Mon, 1 Apr 2024 21:10:43 -0400 [thread overview]
Message-ID: <171202016133.2068687.1746458816502971332.b4-ty@oracle.com> (raw)
In-Reply-To: <20240327020122.439424-1-dlemoal@kernel.org>
On Wed, 27 Mar 2024 11:01:22 +0900, Damien Le Moal wrote:
> Commit b4d3ddd2df7 ("scsi: libsas: Define NCQ Priority sysfs attributes
> for SATA devices") introduced support for ATA NCQ priority control for
> ATA devices managed by libsas. This commit introduces the
> ncq_prio_supported and ncq_prio_enable sysfs device attributes to
> discover and control the use of this features, similarly to libata.
> However, libata publicly declares these device attributes and export
> them for use in ATA low level drivers. This leads to a compilation error
> when libsas and libata are built-in due to the double definition:
>
> [...]
Applied to 6.10/scsi-queue, thanks!
[1/1] scsi: libsas: Fix declaration of ncq priority attributes
https://git.kernel.org/mkp/scsi/c/0ff10cb7f818
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2024-04-02 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 2:01 [PATCH] scsi: libsas: Fix declaration of ncq priority attributes Damien Le Moal
2024-03-27 2:13 ` Damien Le Moal
2024-03-27 14:30 ` John Garry
2024-03-28 0:17 ` Martin K. Petersen
2024-04-02 1:10 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171202016133.2068687.1746458816502971332.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dlemoal@kernel.org \
--cc=geert@linux-m68k.org \
--cc=ipylypiv@google.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).