From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: ufs: qcom: document SC7180 UFS
Date: Thu, 28 Mar 2024 09:52:20 +0100 [thread overview]
Message-ID: <4937df72-9efb-45c5-9c46-2a9d3ec8887f@linaro.org> (raw)
In-Reply-To: <20240328035909.GB3212@thinkpad>
On 28/03/2024 04:59, Manivannan Sadhasivam wrote:
>> - if:
>> properties:
>> compatible:
>> @@ -250,7 +276,7 @@ allOf:
>> reg:
>> maxItems: 1
>> clocks:
>> - minItems: 8
>> + minItems: 7
>> maxItems: 8
>> else:
>> properties:
>> @@ -258,7 +284,7 @@ allOf:
>> minItems: 1
>> maxItems: 2
>> clocks:
>> - minItems: 8
>> + minItems: 7
>
> I'm getting confused by the clock requirements for qcom,ice. Why does specifying
> the qcom,ice phandle require these clocks? These are the UFSHC clocks and
> already defined above.
I am also confused, but I did not change that logic. I don't think that
it is anyway useful, but that separate topic from this patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-28 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 17:46 [PATCH 1/3] dt-bindings: ufs: qcom: document SC8180X UFS Krzysztof Kozlowski
2024-03-26 17:46 ` [PATCH 2/3] dt-bindings: ufs: qcom: document SC7180 UFS Krzysztof Kozlowski
2024-03-28 3:59 ` Manivannan Sadhasivam
2024-03-28 8:52 ` Krzysztof Kozlowski [this message]
2024-03-26 17:46 ` [PATCH 3/3] dt-bindings: ufs: qcom: document SM6125 UFS Krzysztof Kozlowski
2024-03-27 14:31 ` [PATCH 1/3] dt-bindings: ufs: qcom: document SC8180X UFS Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4937df72-9efb-45c5-9c46-2a9d3ec8887f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).