From: KP Singh <kpsingh@kernel.org>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Paul Moore <paul@paul-moore.com>,
Andrii Nakryiko <andrii@kernel.org>,
Kees Cook <keescook@chromium.org>, Song Liu <song@kernel.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
kernel test robot <oliver.sang@intel.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, lkp@intel.com,
oe-lkp@lists.linux.dev
Subject: Re: [kpsingh:static_calls] [security] 9e15595ed0: Kernel_panic-not_syncing:lsm_static_call_init-Ran_out_of_static_slots
Date: Mon, 15 Apr 2024 23:39:08 +0200 [thread overview]
Message-ID: <11DA2A00-28F4-44F8-BBA7-012400FE1050@kernel.org> (raw)
In-Reply-To: <0a4ebcd2-7772-4832-885d-221e0c6f6c04@schaufler-ca.com>
> On 15 Apr 2024, at 22:54, Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> On 4/15/2024 1:42 PM, KP Singh wrote:
>>
>>> On 15 Apr 2024, at 17:47, KP Singh <kpsingh@kernel.org> wrote:
>>>
>>>
>> [...]
>>
>>>> <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>>>> On 2024/04/15 17:26, KP Singh wrote:
>>>>>> This seems like an odd config which does not enable STATIC_CALL, I am going to
>>>>>> make CONFIG_SECURITY depend on CONFIG_STATIC_CALL and make the dependency explicit.
>>>>> If CONFIG_SECURITY depends on CONFIG_STATIC_CALL, architectures which do not
>>>>> support CONFIG_STATIC_CALL can no longer use LSM ? That sounds a bad dependency.
>>>> Agreed. If the arch doesn't support static calls we need a fallback
>>>> solution for the LSM that is no worse than what we have now, and
>>>> preferably would still solve the issue of the BPF hooks active even
>>>> where this is no BPF program attached.
>>> Actually I take it back, when CONFIG_STATIC_CALL is not available, the implementation falls back to an indirect call. This crash is unrelated, I will debug further and post back.
>> Apparently, when I smoke tested, I had CONFIG_IMA disabled so did not hit the bug. Well, now IMA is an LSM, so the following fixes it:
>
> You'll want CONFIG_EVM as well, I bet.
Indeed, thanks Casey!
prev parent reply other threads:[~2024-04-15 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 5:30 [kpsingh:static_calls] [security] 9e15595ed0: Kernel_panic-not_syncing:lsm_static_call_init-Ran_out_of_static_slots kernel test robot
2024-04-15 8:26 ` KP Singh
2024-04-15 13:04 ` Tetsuo Handa
2024-04-15 14:23 ` Paul Moore
[not found] ` <CACYkzJ4G7hO0DNSBy4wpJG1PSgNkifuYcfOeTTpyVBtBtWvQSg@mail.gmail.com>
2024-04-15 15:47 ` KP Singh
2024-04-15 20:42 ` KP Singh
2024-04-15 20:54 ` Casey Schaufler
2024-04-15 21:39 ` KP Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11DA2A00-28F4-44F8-BBA7-012400FE1050@kernel.org \
--to=kpsingh@kernel.org \
--cc=andrii@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).