Linux-Security-Module Archive mirror
 help / color / mirror / Atom feed
From: Fan Wu <wufan@linux.microsoft.com>
To: corbet@lwn.net, zohar@linux.ibm.com, jmorris@namei.org,
	serge@hallyn.com, tytso@mit.edu, ebiggers@kernel.org,
	axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
	eparis@redhat.com, paul@paul-moore.com
Cc: linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org,
	dm-devel@lists.linux.dev, audit@vger.kernel.org,
	linux-kernel@vger.kernel.org, Fan Wu <wufan@linux.microsoft.com>
Subject: [RFC PATCH v13 12/20] dm verity: set DM_TARGET_SINGLETON feature flag
Date: Wed, 28 Feb 2024 16:54:54 -0800	[thread overview]
Message-ID: <1709168102-7677-13-git-send-email-wufan@linux.microsoft.com> (raw)
In-Reply-To: <1709168102-7677-1-git-send-email-wufan@linux.microsoft.com>

The device-mapper has a flag to mark targets as singleton, which is a
required flag for immutable targets. Without this flag, multiple
dm-verity targets can be added to a mapped device, which has no
practical use cases. Also from dm_table_get_immutable_target(),
it documented that "Immutable target is implicitly a singleton".

This patch adds the missing flag, restricting only one
dm-verity target per mapped device.

Signed-off-by: Fan Wu <wufan@linux.microsoft.com>

---
v1-v10:
  + Not present

v11:
  + Introduced

v12:
  + No changes

v13:
  + No changes
---
 drivers/md/dm-verity-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
index 1b591bfa90d5..a99ef30e45ca 100644
--- a/drivers/md/dm-verity-target.c
+++ b/drivers/md/dm-verity-target.c
@@ -1559,7 +1559,7 @@ int dm_verity_get_root_digest(struct dm_target *ti, u8 **root_digest, unsigned i
 
 static struct target_type verity_target = {
 	.name		= "verity",
-	.features	= DM_TARGET_IMMUTABLE,
+	.features	= DM_TARGET_SINGLETON | DM_TARGET_IMMUTABLE,
 	.version	= {1, 10, 0},
 	.module		= THIS_MODULE,
 	.ctr		= verity_ctr,
-- 
2.43.1


  parent reply	other threads:[~2024-02-29  0:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29  0:54 [RFC PATCH v13 00/20] Integrity Policy Enforcement LSM (IPE) Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 01/20] security: add ipe lsm Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 02/20] ipe: add policy parser Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 03/20] ipe: add evaluation loop Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 04/20] ipe: add LSM hooks on execution and kernel read Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 05/20] initramfs|security: Add a security hook to do_populate_rootfs() Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 06/20] ipe: introduce 'boot_verified' as a trust provider Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 07/20] security: add new securityfs delete function Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 08/20] ipe: add userspace interface Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 09/20] uapi|audit|ipe: add ipe auditing support Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 10/20] ipe: add permissive toggle Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 11/20] block|security: add LSM blob to block_device Fan Wu
2024-02-29  0:54 ` Fan Wu [this message]
2024-03-02 16:01   ` [RFC PATCH v13 12/20] dm verity: set DM_TARGET_SINGLETON feature flag Mike Snitzer
2024-02-29  0:54 ` [RFC PATCH v13 13/20] dm: add finalize hook to target_type Fan Wu
2024-03-02 16:13   ` Mike Snitzer
2024-02-29  0:54 ` [RFC PATCH v13 14/20] dm verity: consume root hash digest and signature data via LSM hook Fan Wu
2024-03-02 16:22   ` Mike Snitzer
2024-03-02 16:37   ` Mike Snitzer
2024-02-29  0:54 ` [RFC PATCH v13 15/20] ipe: add support for dm-verity as a trust provider Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 16/20] fsverity: consume builtin signature via LSM hook Fan Wu
2024-02-29  0:54 ` [RFC PATCH v13 17/20] ipe: enable support for fs-verity as a trust provider Fan Wu
2024-02-29  4:01   ` Randy Dunlap
2024-02-29  4:46   ` Eric Biggers
2024-02-29 18:59     ` Fan Wu
2024-02-29 19:42       ` Eric Biggers
2024-02-29 19:59         ` Fan Wu
2024-02-29  0:55 ` [RFC PATCH v13 18/20] scripts: add boot policy generation program Fan Wu
2024-02-29  0:55 ` [RFC PATCH v13 19/20] ipe: kunit test for parser Fan Wu
2024-02-29  0:55 ` [RFC PATCH v13 20/20] documentation: add ipe documentation Fan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1709168102-7677-13-git-send-email-wufan@linux.microsoft.com \
    --to=wufan@linux.microsoft.com \
    --cc=agk@redhat.com \
    --cc=audit@vger.kernel.org \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=dm-devel@lists.linux.dev \
    --cc=ebiggers@kernel.org \
    --cc=eparis@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=snitzer@kernel.org \
    --cc=tytso@mit.edu \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).