From: "Mickaël Salaün" <mic@digikod.net>
To: Kees Cook <keescook@chromium.org>
Cc: "Günther Noack" <gnoack@google.com>,
"Paul Moore" <paul@paul-moore.com>,
"Serge E . Hallyn" <serge@hallyn.com>,
"Konstantin Meskhidze" <konstantin.meskhidze@huawei.com>,
"Shervin Oloumi" <enlightened@chromium.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] landlock: Warn once if a Landlock action is requested while disabled
Date: Mon, 26 Feb 2024 18:16:10 +0100 [thread overview]
Message-ID: <20240226.wu2ageiPi6Ch@digikod.net> (raw)
In-Reply-To: <202402191304.ED03339B@keescook>
On Mon, Feb 19, 2024 at 01:07:48PM -0800, Kees Cook wrote:
> On Mon, Feb 19, 2024 at 08:18:04PM +0100, Mickaël Salaün wrote:
> > Because sandboxing can be used as an opportunistic security measure,
> > user space may not log unsupported features. Let the system
> > administrator know if an application tries to use Landlock but failed
> > because it isn't enabled at boot time. This may be caused by bootloader
> > configurations with outdated "lsm" kernel's command-line parameter.
> >
> > Cc: Günther Noack <gnoack@google.com>
> > Cc: stable@vger.kernel.org
> > Fixes: 265885daf3e5 ("landlock: Add syscall implementations")
> > Signed-off-by: Mickaël Salaün <mic@digikod.net>
> > ---
> > security/landlock/syscalls.c | 18 +++++++++++++++---
> > 1 file changed, 15 insertions(+), 3 deletions(-)
> >
> > diff --git a/security/landlock/syscalls.c b/security/landlock/syscalls.c
> > index f0bc50003b46..b5b424819dee 100644
> > --- a/security/landlock/syscalls.c
> > +++ b/security/landlock/syscalls.c
> > @@ -33,6 +33,18 @@
> > #include "ruleset.h"
> > #include "setup.h"
> >
> > +static bool is_not_initialized(void)
> > +{
> > + if (likely(landlock_initialized))
> > + return false;
> > +
> > + pr_warn_once(
> > + "Disabled but requested by user space. "
> > + "You should enable Landlock at boot time: "
> > + "https://docs.kernel.org/userspace-api/landlock.html#kernel-support\n");
>
> Perhaps update this docs to be really explicit with a example, maybe...
>
> If `landlock` is not present in `CONFIG_LSM`, you can add it. For
> example, if this was the current config::
>
> $ zgrep -h ^CONFIG_LSM= /boot/config-$(uname -r) /proc/config.gz 2>/dev/null
> CONFIG_LSM="lockdown,yama,integrity,apparmor"
>
> You can boot with::
>
> lsm=landlock,lockdown,yama,integrity,apparmor
>
Indeed, I'll send a dedicated patch and update the link accordingly.
>
> I *still* wish we had the "+" operator for lsm=. It would be SO much
> easier to say "boot with lsm=+landlock". *shrug*
I guess it's still possible and it would need to be backported to be
more useful.
>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> --
> Kees Cook
>
next prev parent reply other threads:[~2024-02-26 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 19:18 [PATCH] landlock: Warn once if a Landlock action is requested while disabled Mickaël Salaün
2024-02-19 21:07 ` Kees Cook
2024-02-26 17:16 ` Mickaël Salaün [this message]
2024-02-21 21:35 ` Günther Noack
2024-02-26 17:05 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226.wu2ageiPi6Ch@digikod.net \
--to=mic@digikod.net \
--cc=enlightened@chromium.org \
--cc=gnoack@google.com \
--cc=keescook@chromium.org \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).