From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Aleksandr Nogikh <nogikh@google.com>,
syzbot <syzbot+28aaddd5a3221d7fd709@syzkaller.appspotmail.com>,
axboe@kernel.dk, jmorris@namei.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, paul@paul-moore.com,
serge@hallyn.com, syzkaller-bugs@googlegroups.com,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [syzbot] [hfs] general protection fault in tomoyo_check_acl (3)
Date: Fri, 15 Mar 2024 14:29:17 +0100 [thread overview]
Message-ID: <20240315-zugerechnet-abserviert-36a416bde350@brauner> (raw)
In-Reply-To: <20240314172731.vj4tspj6yudztmxu@quack3>
On Thu, Mar 14, 2024 at 06:27:31PM +0100, Jan Kara wrote:
> Hi Aleksandr,
>
> On Thu 14-03-24 17:21:30, Aleksandr Nogikh wrote:
> > Yes, the CONFIG_BLK_DEV_WRITE_MOUNTED=n change did indeed break our C
> > executor code (and therefore our C reproducers). I posted a fix[1]
> > soon afterwards, but the problem is that syzbot will keep on using old
> > reproducers for old bugs. Syzkaller descriptions change over time, so
> > during bisection and patch testing we have to use the exact syzkaller
> > revision that detected the original bug. All older syzkaller revisions
> > now neither find nor reproduce fs bugs on newer Linux kernel revisions
> > with CONFIG_BLK_DEV_WRITE_MOUNTED=n.
>
> I see, thanks for explanation!
>
> > If the stream of such bisection results is already bothering you and
> > other fs people, a very quick fix could be to ban this commit from the
> > possible bisection results (it's just a one line change in the syzbot
> > config). Then such bugs would just get gradually obsoleted by syzbot
> > without any noise.
>
> It isn't bothering me as such but it results in
> CONFIG_BLK_DEV_WRITE_MOUNTED=n breaking all fs-related reproducers and thus
> making it difficult to evaluate whether the reproducer was somehow
> corrupting the fs image or not. Practically it means closing most
> fs-related syzbot bugs and (somewhat needlessly) starting over from scratch
> with search for reproducers. I'm OK with that although it is a bit
> unfortunate... But I'm pretty sure within a few months syzbot will deliver
> a healthy portion of new issues :)
Fwiw, my take on this is that if an active subsystem (responsive to
syzbot bugs and whatnot) is not able to fix a bug within months given a
reproducer then it's likely that the reproducer is not all that useful.
So by closing that issue and we're hopefully getting a better
reproducer.
prev parent reply other threads:[~2024-03-15 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 12:09 [syzbot] [tomoyo?] [hfs?] general protection fault in tomoyo_check_acl (3) syzbot
2023-07-08 11:29 ` Tetsuo Handa
2024-01-11 6:44 ` [syzbot] [hfs] " syzbot
2024-01-11 9:21 ` Jan Kara
2024-03-10 0:52 ` Tetsuo Handa
2024-03-14 15:54 ` Jan Kara
2024-03-14 16:21 ` Aleksandr Nogikh
2024-03-14 17:27 ` Jan Kara
2024-03-15 13:29 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315-zugerechnet-abserviert-36a416bde350@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=dvyukov@google.com \
--cc=jack@suse.cz \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nogikh@google.com \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=serge@hallyn.com \
--cc=syzbot+28aaddd5a3221d7fd709@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).