From: "Dr. Greg" <greg@enjellic.com>
To: paul@paul-moore.com
Cc: linux-security-module@vger.kernel.org
Subject: TSEM code organization.
Date: Sat, 16 Mar 2024 05:47:14 -0500 [thread overview]
Message-ID: <20240316104714.GA22794@wind.enjellic.com> (raw)
Good morning Paul, I hope your weekend is going well or your week is
starting well, whenever this e-mail finds you.
We've been waiting for the release of 6.8 for the V3 release of TSEM.
TSEM seems to be co-habitating with it reasonably well, modulo some
atomic structure magazine refill issues we are sorting out that appear
to be caused by workqueue scheduling latency differences between this
kernel and older kernels, so we are getting ready to push the V3
release.
Casey has previously raised an issue with the fact that we used a
single include file, tsem.h, for all of the entities that are global
to the various compilation units. We placed that file first in the
patch series so that it could be referenced for review as the
individual compilation units were added.
Everything in that file has a 'tsem_' prefix on it, in one way or
another, so that anyone looking at the code knows that if that prefix
is seen the definition for whatever it is can be found in the global
include file.
Casey advocates that we break the global file into individual include
files that pair with the compilation units and we do appreciate the
concern behind that. However, given that all of the compilation units
reference these global values in one way or another, we will then have
a model where we are introducing code that is using definitions of
things that are not yet available.
You are the final judge and jury on this so we would look to your
advice on how we should proceed. We maintain TSEM across multiple LTS
branches so if we are going to go through the code churn this requires
we only want to do it once and get it over with.
We will look forward to your recommendations on this.
Have a good week/end.
As always,
Dr. Greg
The Quixote Project - Flailing at the Travails of Cybersecurity
https://github.com/Quixote-Project
next reply other threads:[~2024-03-16 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 10:47 Dr. Greg [this message]
2024-03-17 19:20 ` TSEM code organization Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240316104714.GA22794@wind.enjellic.com \
--to=greg@enjellic.com \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).