* [PATCH] apparmor: fix apparmor_socket_post_create() kernel-doc
@ 2024-05-05 22:39 Jeff Johnson
2024-05-10 15:58 ` John Johansen
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnson @ 2024-05-05 22:39 UTC (permalink / raw
To: John Johansen, Paul Moore, James Morris, Serge E. Hallyn
Cc: apparmor, linux-security-module, linux-kernel, Jeff Johnson
make C=1 reports:
security/apparmor/lsm.c:1138: warning: Function parameter or struct member 'protocol' not described in 'apparmor_socket_post_create'
Fix this by correcting the misspelling of 'protocol'.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
security/apparmor/lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index cef8c466af80..d0485fb0ed63 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -1124,7 +1124,7 @@ static int apparmor_socket_create(int family, int type, int protocol, int kern)
* @sock: socket that is being setup
* @family: family of socket being created
* @type: type of the socket
- * @ptotocol: protocol of the socket
+ * @protocol: protocol of the socket
* @kern: socket is a special kernel socket
*
* Note:
---
base-commit: 2c4d8e19cf060744a9db466ffbaea13ab37f25ca
change-id: 20240505-apparmor_socket_post_create-kdoc-897c7ad5d007
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] apparmor: fix apparmor_socket_post_create() kernel-doc
2024-05-05 22:39 [PATCH] apparmor: fix apparmor_socket_post_create() kernel-doc Jeff Johnson
@ 2024-05-10 15:58 ` John Johansen
2024-05-10 19:01 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: John Johansen @ 2024-05-10 15:58 UTC (permalink / raw
To: Jeff Johnson, Paul Moore, James Morris, Serge E. Hallyn
Cc: apparmor, linux-security-module, linux-kernel
On 5/5/24 15:39, Jeff Johnson wrote:
> make C=1 reports:
>
> security/apparmor/lsm.c:1138: warning: Function parameter or struct member 'protocol' not described in 'apparmor_socket_post_create'
>
> Fix this by correcting the misspelling of 'protocol'.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Hey Jeff, thanks for the patch, unfortunately Christian Göttsche version of the patch came in before yours so that is the one I committed
> ---
> security/apparmor/lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cef8c466af80..d0485fb0ed63 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1124,7 +1124,7 @@ static int apparmor_socket_create(int family, int type, int protocol, int kern)
> * @sock: socket that is being setup
> * @family: family of socket being created
> * @type: type of the socket
> - * @ptotocol: protocol of the socket
> + * @protocol: protocol of the socket
> * @kern: socket is a special kernel socket
> *
> * Note:
>
> ---
> base-commit: 2c4d8e19cf060744a9db466ffbaea13ab37f25ca
> change-id: 20240505-apparmor_socket_post_create-kdoc-897c7ad5d007
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] apparmor: fix apparmor_socket_post_create() kernel-doc
2024-05-10 15:58 ` John Johansen
@ 2024-05-10 19:01 ` Jeff Johnson
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-05-10 19:01 UTC (permalink / raw
To: John Johansen, Paul Moore, James Morris, Serge E. Hallyn
Cc: apparmor, linux-security-module, linux-kernel
On 5/10/2024 8:58 AM, John Johansen wrote:
> On 5/5/24 15:39, Jeff Johnson wrote:
>> make C=1 reports:
>>
>> security/apparmor/lsm.c:1138: warning: Function parameter or struct member 'protocol' not described in 'apparmor_socket_post_create'
>>
>> Fix this by correcting the misspelling of 'protocol'.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> Hey Jeff, thanks for the patch, unfortunately Christian Göttsche version of the patch came in before yours so that is the one I committed
np, glad others are helping to clean up :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-10 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-05 22:39 [PATCH] apparmor: fix apparmor_socket_post_create() kernel-doc Jeff Johnson
2024-05-10 15:58 ` John Johansen
2024-05-10 19:01 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).