From: David Gstir <david@sigma-star.at>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Mimi Zohar <zohar@linux.ibm.com>,
James Bottomley <jejb@linux.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Shawn Guo <shawnguo@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Sascha Hauer <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
sigma star Kernel Team <upstream+dcp@sigma-star.at>,
David Howells <dhowells@redhat.com>, Li Yang <leoyang.li@nxp.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Tejun Heo <tj@kernel.org>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v5 4/6] MAINTAINERS: add entry for DCP-based trusted keys
Date: Thu, 7 Mar 2024 16:34:53 +0100 [thread overview]
Message-ID: <2E9B3F32-B162-4C84-81AD-5713EB53A85D@sigma-star.at> (raw)
In-Reply-To: <CZLBYPUU992Q.2PRCZBFNZYWY6@suppilovahvero>
Jarkko,
> On 04.03.2024, at 23:48, Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote:
>> This covers trusted keys backed by NXP's DCP (Data Co-Processor) chip
>> found in smaller i.MX SoCs.
>>
>> Signed-off-by: David Gstir <david@sigma-star.at>
>> ---
>> MAINTAINERS | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 90f13281d297..988d01226131 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11647,6 +11647,15 @@ S: Maintained
>> F: include/keys/trusted_caam.h
>> F: security/keys/trusted-keys/trusted_caam.c
>>
>> +KEYS-TRUSTED-DCP
>> +M: David Gstir <david@sigma-star.at>
>> +R: sigma star Kernel Team <upstream+dcp@sigma-star.at>
>> +L: linux-integrity@vger.kernel.org
>> +L: keyrings@vger.kernel.org
>> +S: Supported
>> +F: include/keys/trusted_dcp.h
>> +F: security/keys/trusted-keys/trusted_dcp.c
>> +
>> KEYS-TRUSTED-TEE
>> M: Sumit Garg <sumit.garg@linaro.org>
>> L: linux-integrity@vger.kernel.org
>
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> I can for sure put this. The code quality is *not* bad :-) However, your
> backing story really needs rework. It is otherwise impossible to
> understand the code changes later on because amount of information is
> vast, and you tend to forget details of stuff that you are not actively
> working on. That is why we care so deeply about them.
got it! :) I’ve tried to rework the commit messages as good as possible
for v6 and will send that series momentarily.
Thanks!
- David
next prev parent reply other threads:[~2024-03-07 15:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 11:06 [PATCH v5 0/6] DCP as trusted keys backend David Gstir
2023-12-15 11:06 ` [PATCH v5 1/6] crypto: mxs-dcp: Add support for hardware-bound keys David Gstir
2024-03-04 22:15 ` Jarkko Sakkinen
2024-03-04 22:27 ` Jarkko Sakkinen
2023-12-15 11:06 ` [PATCH v5 2/6] KEYS: trusted: improve scalability of trust source config David Gstir
2024-03-04 22:35 ` Jarkko Sakkinen
2023-12-15 11:06 ` [PATCH v5 3/6] KEYS: trusted: Introduce NXP DCP-backed trusted keys David Gstir
2024-03-04 22:43 ` Jarkko Sakkinen
2023-12-15 11:06 ` [PATCH v5 4/6] MAINTAINERS: add entry for DCP-based " David Gstir
2024-03-04 22:48 ` Jarkko Sakkinen
2024-03-07 15:34 ` David Gstir [this message]
2023-12-15 11:06 ` [PATCH v5 5/6] docs: document DCP-backed trusted keys kernel params David Gstir
2023-12-15 11:06 ` [PATCH v5 6/6] docs: trusted-encrypted: add DCP as new trust source David Gstir
2023-12-19 0:45 ` [PATCH v5 0/6] DCP as trusted keys backend Paul Moore
2024-03-04 22:51 ` Jarkko Sakkinen
2024-02-05 8:39 ` David Gstir
2024-02-13 9:59 ` Richard Weinberger
2024-02-25 22:20 ` Richard Weinberger
2024-02-26 9:17 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E9B3F32-B162-4C84-81AD-5713EB53A85D@sigma-star.at \
--to=david@sigma-star.at \
--cc=a.fatoum@pengutronix.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=kernel@pengutronix.de \
--cc=keyrings@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=serge@hallyn.com \
--cc=shawnguo@kernel.org \
--cc=tj@kernel.org \
--cc=upstream+dcp@sigma-star.at \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).