From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>,
Casey Schaufler <casey@schaufler-ca.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] security: use default hook return value in call_int_hook()
Date: Thu, 22 Feb 2024 16:52:21 -0500 [thread overview]
Message-ID: <539a7320f63cb88914728368f8e96490@paul-moore.com> (raw)
In-Reply-To: <20240130125659.1709410-1-omosnace@redhat.com>
On Jan 30, 2024 Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> Change the definition of call_int_hook() to treat LSM_RET_DEFAULT(...)
> as the "continue" value instead of 0. To further simplify this macro,
> also drop the IRC argument and replace it with LSM_RET_DEFAULT(...).
>
> After this the macro can be used in a couple more hooks, where similar
> logic is currently open-coded. At the same time, some other existing
> call_int_hook() users now need to be open-coded, but overall it's still
> a net simplification.
>
> There should be no functional change resulting from this patch.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
> security/security.c | 525 +++++++++++++++++++-------------------------
> 1 file changed, 221 insertions(+), 304 deletions(-)
Thanks Ondrej.
Merged into lsm/dev with a fair amount fixups due to merge conflicts
from the IMA/EVM promotion as well as the tweaks in
security_inode_copy_up_xattr() that were discussed in the thread. If
anyone notices anything odd, please let me know.
--
paul-moore.com
prev parent reply other threads:[~2024-02-22 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 12:56 [PATCH] security: use default hook return value in call_int_hook() Ondrej Mosnacek
2024-01-30 16:47 ` Casey Schaufler
2024-02-13 23:14 ` Paul Moore
2024-02-14 1:40 ` Casey Schaufler
2024-02-13 23:10 ` Paul Moore
2024-02-22 21:52 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539a7320f63cb88914728368f8e96490@paul-moore.com \
--to=paul@paul-moore.com \
--cc=casey@schaufler-ca.com \
--cc=linux-security-module@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).