From: Paul Moore <paul@paul-moore.com>
To: linux-security-module@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Roberto Sassu <roberto.sassu@huaweicloud.com>,
linux-integrity@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [GIT PULL] security changes for v6.9-rc3
Date: Tue, 9 Apr 2024 16:14:45 -0400 [thread overview]
Message-ID: <CAHC9VhTF=-Sh6w4icTPA_=A25-EL55Nt-z=mvyb1-vONoN=5wg@mail.gmail.com> (raw)
In-Reply-To: <87le5mxwry.fsf@email.froward.int.ebiederm.org>
On Tue, Apr 9, 2024 at 1:38 PM Eric W. Biederman <ebiederm@xmission.com> wrote:
> Paul Moore <paul@paul-moore.com> writes:
>
> > I know it's everyone's favorite hobby to bash the LSM and LSM devs,
> > but it's important to note that we don't add hooks without working
> > with the associated subsystem devs to get approval.
>
> Hah!!!!
>
> > In the cases
> > where we don't get an explicit ACK, there is an on-list approval, or
> > several ignored on-list attempts over weeks/months/years. We want to
> > be good neighbors.
>
> Hah!!!!
>
> You merged a LSM hook that is only good for breaking chrome's sandbox,
> over my expressed objections. After I tested and verified that
> is what it does.
>
> I asked for testing. None was done. It was claimed that no
> security sensitive code would ever fail to check and deal with
> all return codes, so no testing was necessary. Then later a
> whole bunch of security sensitive code that didn't was found.
>
> The only redeeming grace has been that no-one ever actually uses
> that misbegotten security hook.
>
> P.S. Sorry for this off topic rant but sheesh. At least from
> my perspective you deserve plenty of bashing.
Just in case people are reading this email and don't recall the
security_create_user_ns() hook discussions from 2022, I would suggest
reading those old threads and drawing your own conclusions. A lore
link is below:
https://lore.kernel.org/linux-security-module/?q=s%3Asecurity_create_user_ns
--
paul-moore.com
next prev parent reply other threads:[~2024-04-09 20:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 14:11 [GIT PULL] security changes for v6.9-rc3 Roberto Sassu
2024-04-02 19:39 ` Linus Torvalds
2024-04-02 19:57 ` Linus Torvalds
2024-04-02 21:00 ` Al Viro
2024-04-02 21:35 ` Linus Torvalds
2024-04-02 21:36 ` Paul Moore
2024-04-02 22:42 ` Al Viro
2024-04-03 2:21 ` Paul Moore
2024-04-09 17:37 ` Eric W. Biederman
2024-04-09 20:14 ` Paul Moore [this message]
2024-04-02 20:27 ` Paul Moore
2024-04-02 20:28 ` Paul Moore
-- strict thread matches above, loose matches on Subject: below --
2024-04-02 9:21 Roberto Sassu
2024-04-02 12:15 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhTF=-Sh6w4icTPA_=A25-EL55Nt-z=mvyb1-vONoN=5wg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=ebiederm@xmission.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).