From: John Johansen <john.johansen@canonical.com>
To: Xiao Liang <shaw.leon@gmail.com>
Cc: linux-security-module@vger.kernel.org,
Matthew Garrett <mjg59@google.com>
Subject: Re: [PATCH] apparmor: Fix null pointer deref when receiving skb during sock creation
Date: Sat, 27 Jan 2024 00:20:04 -0800 [thread overview]
Message-ID: <a651b115-1fa8-4de8-a05f-e1c2b3423816@canonical.com> (raw)
In-Reply-To: <CABAhCOQDQV_LHXv5-aosJu9+sP6wE9kDgYB8n-hYB=XKS0B_fg@mail.gmail.com>
On 1/22/24 22:16, Xiao Liang wrote:
> On Mon, Oct 16, 2023 at 11:36 AM John Johansen
> <john.johansen@canonical.com> wrote:
>>
>> On 9/1/23 17:48, Xiao Liang wrote:
>>> The panic below is observed when receiving ICMP packets with secmark set
>>> while an ICMP raw socket is being created. SK_CTX(sk)->label is updated
>>> in apparmor_socket_post_create(), but the packet is delivered to the
>>> socket before that, causing the null pointer dereference.
>>> Drop the packet if label context is not set.
>>
>> not sure how I dropped this one, thanks for the patch. I have pulled it into the apparmor tree
>>
>
> I haven't seen this patch in the tree yet. May I know the status?
sorry, this did get pulled in, but for some reason, didn't get promoted into apparmor-next
I will try to send it up for -rc3
prev parent reply other threads:[~2024-01-27 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 0:48 [PATCH] apparmor: Fix null pointer deref when receiving skb during sock creation Xiao Liang
2023-10-16 3:36 ` John Johansen
2024-01-23 6:16 ` Xiao Liang
2024-01-27 8:20 ` John Johansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a651b115-1fa8-4de8-a05f-e1c2b3423816@canonical.com \
--to=john.johansen@canonical.com \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg59@google.com \
--cc=shaw.leon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).