From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Roberto Sassu <roberto.sassu@huawei.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Eric Snowberg <eric.snowberg@oracle.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH][next] integrity: Avoid -Wflex-array-member-not-at-end warnings
Date: Wed, 20 Mar 2024 21:39:32 -0600 [thread overview]
Message-ID: <fe36683b-ec78-4f83-b4ad-8dca35e4fa09@embeddedor.com> (raw)
In-Reply-To: <bbae0060d6ed7a0b033dc07e8d26c9d68585080b.camel@linux.ibm.com>
On 20/03/24 19:19, Mimi Zohar wrote:
> Hi Gustavo,
>
> Sorry for the delay...
No worries. :)
>
> On Mon, 2024-03-04 at 11:52 -0600, Gustavo A. R. Silva wrote:
>> -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting
>> ready to enable it globally.
>>
>> There is currently an object (`hdr)` in `struct ima_max_digest_data`
>> that contains a flexible structure (`struct ima_digest_data`):
>>
>> struct ima_max_digest_data {
>> struct ima_digest_data hdr;
>> u8 digest[HASH_MAX_DIGESTSIZE];
>> } __packed;
>>
>> So, in order to avoid ending up with a flexible-array member in the
>> middle of another struct, we use the `struct_group_tagged()` helper to
>> separate the flexible array from the rest of the members in the flexible
>> structure:
>>
>> struct ima_digest_data {
>> struct_group_tagged(ima_digest_data_hdr, hdr,
>>
>> ... the rest of the members
>>
>> );
>> u8 digest[];
>> } __packed;
>>
>> With the change described above, we can now declare an object of the
>> type of the tagged struct, without embedding the flexible array in the
>> middle of another struct:
>>
>> struct ima_max_digest_data {
>> struct ima_digest_data_hdr hdr;
>> u8 digest[HASH_MAX_DIGESTSIZE];
>> } __packed;
>>
>> We also use `container_of()` whenever we need to retrieve a pointer to
>> the flexible structure.
>
> Nice!
>
>>
>> So, with these changes, fix the following warnings:
>>
>> security/integrity/evm/evm.h:45:32: warning: structure containing a flexible
>> array member is not at the end of another structure [-Wflex-array-member-not-
>> at-end]
>> security/integrity/evm/evm.h:45:32: warning: structure containing a flexible
>> array member is not at the end of another structure [-Wflex-array-member-not-
>> at-end]
>> security/integrity/evm/evm.h:45:32: warning: structure containing a flexible
>> array member is not at the end of another structure [-Wflex-array-member-not-
>> at-end]
>
> A similar change would need to be made to struct evm_digest:
>
> struct evm_digest {
> struct ima_digest_data hdr;
> char digest[IMA_MAX_DIGEST_SIZE];
> } __packed;
>
> Is there are another patch?
Oh, I missed that one. I'll include it and send v2, shortly.
Thanks!
--
Gustavo
prev parent reply other threads:[~2024-03-21 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 17:52 [PATCH][next] integrity: Avoid -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2024-03-19 18:44 ` Gustavo A. R. Silva
2024-03-21 1:19 ` Mimi Zohar
2024-03-21 3:39 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe36683b-ec78-4f83-b4ad-8dca35e4fa09@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=gustavoars@kernel.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).