Linux-Serial Archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 2/2] dt-bindings: serial: Add support for enabling RS485 mode via GPIO at boot time
@ 2023-11-21  8:28 Tomas Paukrt
  2023-11-27 20:01 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Tomas Paukrt @ 2023-11-21  8:28 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-kernel, linux-serial, devicetree

Add an option to enable the RS485 mode at boot time based on
the state of a GPIO pin (DIP switch or configuration jumper).
The GPIO is defined by the device tree property "linux,rs485-mode-gpio".

Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
---
 Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
index 9418fd6..7a72f37 100644
--- a/Documentation/devicetree/bindings/serial/rs485.yaml
+++ b/Documentation/devicetree/bindings/serial/rs485.yaml
@@ -47,6 +47,10 @@ properties:
       later with proper ioctl.
     $ref: /schemas/types.yaml#/definitions/flag

+  linux,rs485-mode-gpio:
+    description: GPIO pin to enable RS485 mode at boot time.
+    maxItems: 1
+
   rs485-rx-during-tx:
     description: enables the receiving of data even while sending data.
     $ref: /schemas/types.yaml#/definitions/flag
--
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4 2/2] dt-bindings: serial: Add support for enabling RS485 mode via GPIO at boot time
  2023-11-21  8:28 [PATCH v4 2/2] dt-bindings: serial: Add support for enabling RS485 mode via GPIO at boot time Tomas Paukrt
@ 2023-11-27 20:01 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-11-27 20:01 UTC (permalink / raw)
  To: Tomas Paukrt
  Cc: Greg Kroah-Hartman, Jiri Slaby, Krzysztof Kozlowski, Conor Dooley,
	linux-kernel, linux-serial, devicetree

On Tue, Nov 21, 2023 at 09:28:12AM +0100, Tomas Paukrt wrote:
> Add an option to enable the RS485 mode at boot time based on
> the state of a GPIO pin (DIP switch or configuration jumper).
> The GPIO is defined by the device tree property "linux,rs485-mode-gpio".
> 
> Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
> ---
>  Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
> index 9418fd6..7a72f37 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
> @@ -47,6 +47,10 @@ properties:
>        later with proper ioctl.
>      $ref: /schemas/types.yaml#/definitions/flag
> 
> +  linux,rs485-mode-gpio:

This has little to do with Linux, so no need for linux prefix.

The preferred form is always plural '-gpios'.

> +    description: GPIO pin to enable RS485 mode at boot time.
> +    maxItems: 1
> +
>    rs485-rx-during-tx:
>      description: enables the receiving of data even while sending data.
>      $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-27 20:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21  8:28 [PATCH v4 2/2] dt-bindings: serial: Add support for enabling RS485 mode via GPIO at boot time Tomas Paukrt
2023-11-27 20:01 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).