From: Dhruva Gole <d-gole@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Petr Mladek" <pmladek@suse.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"David S . Miller" <davem@davemloft.net>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Sebastian Reichel" <sre@kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v7 4/7] serial: core: Add support for DEVNAME:0.0 style naming for kernel console
Date: Thu, 28 Mar 2024 16:03:10 +0530 [thread overview]
Message-ID: <20240328103310.hd4z2bt6cvje5hbo@dhruva> (raw)
In-Reply-To: <2024032859-subscript-marshy-7508@gregkh>
On Mar 28, 2024 at 08:22:26 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 28, 2024 at 12:01:52PM +0530, Dhruva Gole wrote:
> > Hi,
> >
> > On Mar 27, 2024 at 12:59:38 +0200, Tony Lindgren wrote:
> > > We can now add hardware based addressing for serial ports. Starting with
> > > commit 84a9582fd203 ("serial: core: Start managing serial controllers to
> > > enable runtime PM"), and all the related fixes to this commit, the serial
> > > core now knows to which serial port controller the ports are connected.
[...]
> > >
> > > +#ifdef CONFIG_SERIAL_CORE_CONSOLE
> > > +
> > > +static int serial_base_add_one_prefcon(const char *match, const char *dev_name,
> > > + int port_id)
> > > +{
> > > + int ret;
> > > +
> > > + ret = add_preferred_console_match(match, dev_name, port_id);
> > > + if (ret == -ENOENT)
> > > + return 0;
> > > +
> > > + return ret;
> >
> > Can we do this instead?
> > return (ret == -ENOENT ? 0 : ret);
>
> No, please no.
>
> Just spell it out, like was done here, dealing with ? : is a pain to
> read and follow and the generated code should be identical.
>
> Only use ? : in places where it's the only way to do it (i.e. as
> function parameters or in printk-like lines.)
>
> Write for people first, compilers second.
Okay understood, I will keep this in mind from now on.
Thanks.
Tony,
Please feel free to take my R-by and ignore this suggestion as per
Greg's comments.
--
Best regards,
Dhruva
next prev parent reply other threads:[~2024-03-28 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 10:59 [PATCH v7 0/7] Add support for DEVNAME:0.0 style hardware based addressing Tony Lindgren
2024-03-27 10:59 ` [PATCH v7 1/7] printk: Save console options for add_preferred_console_match() Tony Lindgren
2024-03-27 13:36 ` Andy Shevchenko
2024-05-24 16:06 ` Petr Mladek
2024-05-27 11:13 ` Tony Lindgren
2024-05-27 13:45 ` Petr Mladek
2024-05-28 5:05 ` Tony Lindgren
2024-05-31 6:54 ` Tony Lindgren
2024-03-27 10:59 ` [PATCH v7 2/7] printk: Don't try to parse DEVNAME:0.0 console options Tony Lindgren
2024-03-27 10:59 ` [PATCH v7 3/7] printk: Flag register_console() if console is set on command line Tony Lindgren
2024-03-27 10:59 ` [PATCH v7 4/7] serial: core: Add support for DEVNAME:0.0 style naming for kernel console Tony Lindgren
2024-03-28 6:31 ` Dhruva Gole
2024-03-28 7:22 ` Greg Kroah-Hartman
2024-03-28 10:33 ` Dhruva Gole [this message]
2024-03-27 10:59 ` [PATCH v7 5/7] serial: core: Handle serial console options Tony Lindgren
2024-03-27 10:59 ` [PATCH v7 6/7] serial: 8250: Add preferred console in serial8250_isa_init_ports() Tony Lindgren
2024-03-27 10:59 ` [PATCH v7 7/7] Documentation: kernel-parameters: Add DEVNAME:0.0 format for serial ports Tony Lindgren
2024-03-28 6:05 ` Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328103310.hd4z2bt6cvje5hbo@dhruva \
--to=d-gole@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).