From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gong Ruiqi <gongruiqi1@huawei.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Jon Ringle <jringle@gridpoint.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Wang Weiyang <wangweiyang2@huawei.com>,
stable@vger.kernel.org
Subject: Re: [PATCH stable 5.10] serial: sc16is7xx: convert from _raw_ to _noinc_ regmap functions for FIFO
Date: Fri, 29 Mar 2024 10:39:21 +0100 [thread overview]
Message-ID: <2024032926-wielder-recreate-be4a@gregkh> (raw)
In-Reply-To: <07a3c30d-5a81-4b99-8090-38753b650432@huawei.com>
On Mon, Mar 18, 2024 at 11:14:13AM +0800, Gong Ruiqi wrote:
> Oops. + Cc stable@vger.kernel.org
>
> On 2024/03/18 10:52, GONG, Ruiqi wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > commit dbf4ab821804df071c8b566d9813083125e6d97b upstream.
> >
> > The SC16IS7XX IC supports a burst mode to access the FIFOs where the
> > initial register address is sent ($00), followed by all the FIFO data
> > without having to resend the register address each time. In this mode, the
> > IC doesn't increment the register address for each R/W byte.
> >
> > The regmap_raw_read() and regmap_raw_write() are functions which can
> > perform IO over multiple registers. They are currently used to read/write
> > from/to the FIFO, and although they operate correctly in this burst mode on
> > the SPI bus, they would corrupt the regmap cache if it was not disabled
> > manually. The reason is that when the R/W size is more than 1 byte, these
> > functions assume that the register address is incremented and handle the
> > cache accordingly.
> >
> > Convert FIFO R/W functions to use the regmap _noinc_ versions in order to
> > remove the manual cache control which was a workaround when using the
> > _raw_ versions. FIFO registers are properly declared as volatile so
> > cache will not be used/updated for FIFO accesses.
> >
> > Fixes: dfeae619d781 ("serial: sc16is7xx")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > Link: https://lore.kernel.org/r/20231211171353.2901416-6-hugo@hugovil.com
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
> > ---
> >
> > The mainline commit dbf4ab821804 ("serial: sc16is7xx: convert from _raw_
> > to _noinc_ regmap functions for FIFO") by Hugo has been assigned to be
> > CVE-2023-52488, but for stable branches lower than 6.1 there's no
> > official backport.
> >
> > I made up this backport patch for 5.10, and its correctness has been
> > confirmed in previous communication with Hugo. Let's publicize it and
> > merge it into upstream.
I can not take this only in 5.10, it needs to also go into 5.15.y first,
right?
Please resend a 5.15.y and this 5.10.y version when you have both of
them (the 5.10.y version wasn't sent to stable@k.o so it's hard to track
down), and we will be glad to take them both.
thanks,
greg k-h
prev parent reply other threads:[~2024-03-29 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 2:52 [PATCH stable 5.10] serial: sc16is7xx: convert from _raw_ to _noinc_ regmap functions for FIFO GONG, Ruiqi
2024-03-18 3:14 ` Gong Ruiqi
2024-03-29 9:39 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032926-wielder-recreate-be4a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gongruiqi1@huawei.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wangweiyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).