From: Konstantin Pugin <rilian.la.te@ya.ru>
Cc: krzk@kernel.org, conor@kernel.org, lkp@intel.com, vz@mleia.com,
robh@kernel.org, jcmvbkbc@gmail.com, nicolas.ferre@microchip.com,
manikanta.guntupalli@amd.com, corbet@lwn.net,
ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de,
Maarten.Brock@sttls.nl, linux-stable@vger.kernel.org,
"Konstantin Pugin" <rilian.la.te@ya.ru>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lech Perczak" <lech.perczak@camlingroup.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH 0/1] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
Date: Sun, 28 Apr 2024 17:45:32 +0300 [thread overview]
Message-ID: <20240428144541.80812-1-rilian.la.te@ya.ru> (raw)
When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration,
we get the following warning after commit 4afeced55baa ("serial: core:
fix sanitizing check for RTS settings"):
invalid RTS setting, using RTS_AFTER_SEND instead
This results in SER_RS485_RTS_AFTER_SEND being set and the
driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT,
which breaks some hardware using these chips.
The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix
this by announcing support for RTS_ON_SEND.
This patch is extracted from my XR20M117X series as it is affect all SC16IS7XX hardware.
This bug affects all kernel series from 6.1 onwards.
Konstantin Pugin (1):
serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
drivers/tty/serial/sc16is7xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 660a708098569a66a47d0abdad998e29e1259de6
--
2.44.0
next reply other threads:[~2024-04-28 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:45 Konstantin Pugin [this message]
2024-04-28 14:45 ` [PATCH 1/1] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND Konstantin Pugin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428144541.80812-1-rilian.la.te@ya.ru \
--to=rilian.la.te@ya.ru \
--cc=Maarten.Brock@sttls.nl \
--cc=andy@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzk@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stable@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manikanta.guntupalli@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).