From: Greg KH <gregkh@linuxfoundation.org>
To: Lu Dai <dai.lu@exordes.com>
Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu,
naveen.n.rao@linux.ibm.com, mpe@ellerman.id.au,
jirislaby@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
javier.carrasco.cruz@gmail.com, shuah@kernel.org,
julia.lawall@inria.fr
Subject: Re: [PATCH V2] tty: hvc: hvc_opal: eliminate uses of of_node_put()
Date: Fri, 3 May 2024 15:58:13 +0200 [thread overview]
Message-ID: <2024050323-rhyme-upchuck-4c4c@gregkh> (raw)
In-Reply-To: <20240503135215.252635-1-dai.lu@exordes.com>
On Fri, May 03, 2024 at 04:52:15PM +0300, Lu Dai wrote:
> Make use of the __free() cleanup handler to automatically free nodes
> when they get out of scope.
>
> Remove the need for a 'goto' as an effect.
>
> Signed-off-by: Lu Dai <dai.lu@exordes.com>
> ---
> Changes since v1:
> Move the assignment of 'opal' to its declaration
> Seperate the declaration of 'np'
>
> drivers/tty/hvc/hvc_opal.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 095c33ad10f8..c17e8343ea60 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -327,19 +327,18 @@ static void udbg_init_opal_common(void)
>
> void __init hvc_opal_init_early(void)
> {
> - struct device_node *stdout_node = of_node_get(of_stdout);
> + struct device_node *stdout_node __free(device_node) = of_node_get(of_stdout);
> const __be32 *termno;
> const struct hv_ops *ops;
> u32 index;
>
> /* If the console wasn't in /chosen, try /ibm,opal */
> if (!stdout_node) {
> - struct device_node *opal, *np;
> -
> /* Current OPAL takeover doesn't provide the stdout
> * path, so we hard wire it
> */
> - opal = of_find_node_by_path("/ibm,opal/consoles");
> + struct device_node *opal __free(device_node) =
> + of_find_node_by_path("/ibm,opal/consoles");
> if (opal) {
No blank line?
> pr_devel("hvc_opal: Found consoles in new location\n");
> } else {
> @@ -350,13 +349,13 @@ void __init hvc_opal_init_early(void)
> }
> if (!opal)
> return;
> + struct device_node *np;
> for_each_child_of_node(opal, np) {
Ick, no, don't do that please. Take some time and become more familiar
with kernel coding style and issues, perhaps work in drivers/staging/
first, before attempting to do stuff like this that is not correct.
thanks,
greg k-h
prev parent reply other threads:[~2024-05-03 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 13:52 [PATCH V2] tty: hvc: hvc_opal: eliminate uses of of_node_put() Lu Dai
2024-05-03 13:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024050323-rhyme-upchuck-4c4c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dai.lu@exordes.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jirislaby@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).