From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jo Van Bulck" <jo.vanbulck@cs.kuleuven.be>,
<kai.huang@intel.com>, <linux-sgx@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v6 06/13] selftests/sgx: Remove redundant enclave base address save/restore
Date: Mon, 25 Sep 2023 19:44:20 +0300 [thread overview]
Message-ID: <CVS5EA0J0L3K.3KYP9Y9K9DRSY@suppilovahvero> (raw)
In-Reply-To: <20230921143604.6561-7-jo.vanbulck@cs.kuleuven.be>
On Thu Sep 21, 2023 at 5:35 PM EEST, Jo Van Bulck wrote:
> Remove redundant push/pop pair that stores and restores the enclave base
> address in the test enclave, as it is never used after the pop and can
> anyway be easily retrieved via the __encl_base symbol.
>
> Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
> Acked-by: Kai Huang <kai.huang@intel.com>
> ---
> tools/testing/selftests/sgx/test_encl_bootstrap.S | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/sgx/test_encl_bootstrap.S b/tools/testing/selftests/sgx/test_encl_bootstrap.S
> index 03ae0f57e29d..e0ce993d3f2c 100644
> --- a/tools/testing/selftests/sgx/test_encl_bootstrap.S
> +++ b/tools/testing/selftests/sgx/test_encl_bootstrap.S
> @@ -55,12 +55,9 @@ encl_entry_core:
> push %rax
>
> push %rcx # push the address after EENTER
> - push %rbx # push the enclave base address
>
> call encl_body
>
> - pop %rbx # pop the enclave base address
> -
> /* Clear volatile GPRs, except RAX (EEXIT function). */
> xor %rcx, %rcx
> xor %rdx, %rdx
> --
> 2.25.1
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2023-09-25 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:35 [PATCH v6 00/13] selftests/sgx: Fix compilation errors Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 01/13] selftests/sgx: Fix uninitialized pointer dereference in error path Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 02/13] selftests/sgx: Fix uninitialized pointer dereferences in encl_get_entry Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 03/13] selftests/sgx: Include memory clobber for inline asm in test enclave Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 04/13] selftests/sgx: Separate linker options Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 05/13] selftests/sgx: Specify freestanding environment for enclave compilation Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 06/13] selftests/sgx: Remove redundant enclave base address save/restore Jo Van Bulck
2023-09-25 16:44 ` Jarkko Sakkinen [this message]
2023-09-21 14:35 ` [PATCH v6 07/13] selftests/sgx: Produce static-pie executable for test enclave Jo Van Bulck
2023-09-21 14:35 ` [PATCH v6 08/13] selftests/sgx: Handle relocations in " Jo Van Bulck
2023-09-21 14:36 ` [PATCH v6 09/13] selftests/sgx: Fix linker script asserts Jo Van Bulck
2023-09-21 14:36 ` [PATCH v6 10/13] selftests/sgx: Ensure test enclave buffer is entirely preserved Jo Van Bulck
2023-09-21 14:36 ` [PATCH v6 11/13] selftests/sgx: Ensure expected location of test enclave buffer Jo Van Bulck
2023-09-21 14:36 ` [PATCH v6 12/13] selftests/sgx: Discard unsupported ELF sections Jo Van Bulck
2023-09-21 14:36 ` [PATCH v6 13/13] selftests/sgx: Remove incomplete ABI sanitization code in test enclave Jo Van Bulck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CVS5EA0J0L3K.3KYP9Y9K9DRSY@suppilovahvero \
--to=jarkko@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=jo.vanbulck@cs.kuleuven.be \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).