From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Yoshinori Sato <ysato@users.osdn.me>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Shuah Khan <shuah@kernel.org>,
linux-sh@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests/nolibc: use file driver for QEMU serial
Date: Fri, 20 Jun 2025 09:51:26 +0200 [thread overview]
Message-ID: <20250620075126.GB22550@1wt.eu> (raw)
In-Reply-To: <20250609-nolibc-sh-v1-2-9dcdb1b66bb5@weissschuh.net>
Hi Thomas,
On Mon, Jun 09, 2025 at 11:28:58AM +0200, Thomas Weißschuh wrote:
> For the test implementation of the SuperH architecture a second serial
> serial port needs to be used. Unfortunately the currently used 'stdio'
> driver does not support multiple serial ports at the same time.
>
> Switch to the 'file' driver which does support multiple ports and is
> sufficient for the nolibc-test usecase.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> tools/testing/selftests/nolibc/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
> index 22da78a4bfea0274f66abec319d34b3d2a2824ac..238acaa7bb06dcdbcadd9d3190c2de726e1a40b1 100644
> --- a/tools/testing/selftests/nolibc/Makefile
> +++ b/tools/testing/selftests/nolibc/Makefile
> @@ -315,12 +315,12 @@ kernel-standalone: initramfs | defconfig
>
> # run the tests after building the kernel
> run: kernel initramfs.cpio
> - $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(IMAGE)" -initrd initramfs.cpio -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out"
> + $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(IMAGE)" -initrd initramfs.cpio -serial file:/dev/stdout $(QEMU_ARGS) > "$(CURDIR)/run.out"
> $(Q)$(REPORT) $(CURDIR)/run.out
>
> # re-run the tests from an existing kernel
> rerun:
> - $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(IMAGE)" -initrd initramfs.cpio -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out"
> + $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(IMAGE)" -initrd initramfs.cpio -serial file:/dev/stdout $(QEMU_ARGS) > "$(CURDIR)/run.out"
I'm cautious every time we touch the -serial output after having faced
issues earlier when trying to use pipes. Here I think it's OK, however,
I'm wondering if "file:$(CURDIR)/run.out" wouldn't be clearer, and also
encourage future changes to stick to a file and avoid piping the output
to a filter command. No strong opinion though.
In any case: Acked-by: Willy Tarreau <w@1wt.eu>
Thanks,
Willy
next prev parent reply other threads:[~2025-06-20 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 9:28 [PATCH 0/3] tools/nolibc: add support for SuperH Thomas Weißschuh
2025-06-09 9:28 ` [PATCH 1/3] selftests/nolibc: fix EXTRACONFIG variables ordering Thomas Weißschuh
2025-06-09 9:28 ` [PATCH 2/3] selftests/nolibc: use file driver for QEMU serial Thomas Weißschuh
2025-06-20 7:51 ` Willy Tarreau [this message]
2025-06-09 9:28 ` [PATCH 3/3] tools/nolibc: add support for SuperH Thomas Weißschuh
2025-06-09 9:53 ` [PATCH 0/3] " John Paul Adrian Glaubitz
2025-06-09 10:05 ` Thomas Weißschuh
2025-06-25 2:41 ` Rob Landley
2025-06-25 14:13 ` Thomas Weißschuh
2025-06-25 15:52 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620075126.GB22550@1wt.eu \
--to=w@1wt.eu \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
--cc=ysato@users.osdn.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).