Linux-sh Archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "kernel test robot" <lkp@intel.com>,
	"Marek Behún" <kabel@kernel.org>,
	oe-kbuild-all@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, arm <arm@kernel.org>,
	linux-sh@vger.kernel.org,
	"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>
Subject: Re: [soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!
Date: Fri, 21 Mar 2025 11:41:59 +0100	[thread overview]
Message-ID: <86813d50-d4c2-4220-a5a8-2a264b37f7d4@app.fastmail.com> (raw)
In-Reply-To: <CAMuHMdUeynpmUUmZPViEBttANFmEhpjFn0wqNc1wQB6wRbd0rQ@mail.gmail.com>

On Fri, Mar 21, 2025, at 10:36, Geert Uytterhoeven wrote:
>> >
>> > ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
>
> Bug in driver (must not use __delay() directly).
>
>> > ERROR: modpost: "devm_of_clk_add_hw_provider"
>> > [drivers/media/i2c/tc358746.ko] undefined!
>> > ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko]
>> > undefined!
>> > ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko]
>> > undefined!
>
> Missing dependencies for driver.

Agreed, but both of these only break the build on sh because
the architecture code is different from the others. It's obviously
best to fix these in the drivers, I just wouldn't expect the
driver maintainers to care unless someone sends them a patch/

>> >>> ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!
>>
>> This comes from __bf_shf(spec) in omnia_mcu_request_irq().
>>
>> As far as I can tell, this is not your problem but in the
>> SH architecture missing one of the libgcc functions that are
>> called by gcc.
>>
>> Since this is only for compile-testing sh allmodconfig, and
>> that is already broken because of other bugs, I'm not going
>> to care either.
>>
>> Adding the linux-sh list to Cc, it would be nice to get a clean
>> build again. All four problems should be trivial to address,
>> and some of these have been broken for many years.
>
> So one SH-specific issue to fix...

There is also the missing clone3 syscall that has been
causing a warning for many years.

      Arnd

      reply	other threads:[~2025-03-21 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202503211029.DnQpqsJs-lkp@intel.com>
2025-03-21  8:40 ` [soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined! Arnd Bergmann
2025-03-21  9:36   ` Geert Uytterhoeven
2025-03-21 10:41     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86813d50-d4c2-4220-a5a8-2a264b37f7d4@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=kabel@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).