From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: linux-sh@vger.kernel.org, ysato@users.sourceforge.jp, dalias@libc.org
Subject: Re: [PATCH -next] sh: Remove obsoleted declarations for make_maskreg_irq and irq_mask_register
Date: Thu, 26 Sep 2024 14:26:20 +0200 [thread overview]
Message-ID: <95401772af7f0d8ce83e608463b245fca9e565f4.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20240824120609.2519181-1-cuigaosheng1@huawei.com>
On Sat, 2024-08-24 at 20:06 +0800, Gaosheng Cui wrote:
> The make_maskreg_irq() and irq_mask_register have been removed since
> commit 5a4053b23262 ("sh: Kill off dead boards."), and now they are
> useless, so remove them.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> arch/sh/include/asm/irq.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/sh/include/asm/irq.h b/arch/sh/include/asm/irq.h
> index 0f384b1f45ca..53fc18a3d4c2 100644
> --- a/arch/sh/include/asm/irq.h
> +++ b/arch/sh/include/asm/irq.h
> @@ -13,12 +13,6 @@
> */
> #define NO_IRQ_IGNORE ((unsigned int)-1)
>
> -/*
> - * Simple Mask Register Support
> - */
> -extern void make_maskreg_irq(unsigned int irq);
> -extern unsigned short *irq_mask_register;
> -
> /*
> * PINT IRQs
> */
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Thanks for catching this. Will pick this up later today.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2024-09-26 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 12:06 [PATCH -next] sh: Remove obsoleted declarations for make_maskreg_irq and irq_mask_register Gaosheng Cui
2024-09-26 12:26 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95401772af7f0d8ce83e608463b245fca9e565f4.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=cuigaosheng1@huawei.com \
--cc=dalias@libc.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).