From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com,
tglx@linutronix.de, david@redhat.com, jannh@google.com,
hughd@google.com, yuzhao@google.com, willy@infradead.org,
muchun.song@linux.dev, vbabka@kernel.org,
lorenzo.stoakes@oracle.com, akpm@linux-foundation.org,
rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de,
will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com,
dave.hansen@linux.intel.com, rppt@kernel.org,
ryan.roberts@arm.com, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-um@lists.infradead.org
Subject: Re: [PATCH v4 15/15] mm: pgtable: introduce generic pagetable_dtor_free()
Date: Tue, 7 Jan 2025 15:22:15 +0100 [thread overview]
Message-ID: <Z304l1Y6DHosXlBh@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com> (raw)
In-Reply-To: <cb5700c21d0eed9eb50bac385be1fb6cdef7e530.1735549103.git.zhengqi.arch@bytedance.com>
On Mon, Dec 30, 2024 at 05:07:50PM +0800, Qi Zheng wrote:
> The pte_free(), pmd_free(), __pud_free() and __p4d_free() in
> asm-generic/pgalloc.h and the generic __tlb_remove_table() are basically
> the same, so let's introduce pagetable_dtor_free() to deduplicate them.
>
> In addition, the pagetable_dtor_free() in s390 does the same thing, so
> let's s390 also calls generic pagetable_dtor_free().
>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> arch/s390/mm/pgalloc.c | 6 ------
> include/asm-generic/pgalloc.h | 12 ++++--------
> include/asm-generic/tlb.h | 3 +--
> include/linux/mm.h | 6 ++++++
> 4 files changed, 11 insertions(+), 16 deletions(-)
>
> diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c
> index 3e002dea6278f..a4e7619020931 100644
> --- a/arch/s390/mm/pgalloc.c
> +++ b/arch/s390/mm/pgalloc.c
> @@ -180,12 +180,6 @@ unsigned long *page_table_alloc(struct mm_struct *mm)
> return table;
> }
>
> -static void pagetable_dtor_free(struct ptdesc *ptdesc)
> -{
> - pagetable_dtor(ptdesc);
> - pagetable_free(ptdesc);
> -}
> -
> void page_table_free(struct mm_struct *mm, unsigned long *table)
> {
> struct ptdesc *ptdesc = virt_to_ptdesc(table);
> diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h
> index 4afb346eae255..e3977ddca15e4 100644
> --- a/include/asm-generic/pgalloc.h
> +++ b/include/asm-generic/pgalloc.h
> @@ -109,8 +109,7 @@ static inline void pte_free(struct mm_struct *mm, struct page *pte_page)
> {
> struct ptdesc *ptdesc = page_ptdesc(pte_page);
>
> - pagetable_dtor(ptdesc);
> - pagetable_free(ptdesc);
> + pagetable_dtor_free(ptdesc);
> }
>
>
> @@ -153,8 +152,7 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd)
> struct ptdesc *ptdesc = virt_to_ptdesc(pmd);
>
> BUG_ON((unsigned long)pmd & (PAGE_SIZE-1));
> - pagetable_dtor(ptdesc);
> - pagetable_free(ptdesc);
> + pagetable_dtor_free(ptdesc);
> }
> #endif
>
> @@ -202,8 +200,7 @@ static inline void __pud_free(struct mm_struct *mm, pud_t *pud)
> struct ptdesc *ptdesc = virt_to_ptdesc(pud);
>
> BUG_ON((unsigned long)pud & (PAGE_SIZE-1));
> - pagetable_dtor(ptdesc);
> - pagetable_free(ptdesc);
> + pagetable_dtor_free(ptdesc);
> }
>
> #ifndef __HAVE_ARCH_PUD_FREE
> @@ -248,8 +245,7 @@ static inline void __p4d_free(struct mm_struct *mm, p4d_t *p4d)
> struct ptdesc *ptdesc = virt_to_ptdesc(p4d);
>
> BUG_ON((unsigned long)p4d & (PAGE_SIZE-1));
> - pagetable_dtor(ptdesc);
> - pagetable_free(ptdesc);
> + pagetable_dtor_free(ptdesc);
> }
>
> #ifndef __HAVE_ARCH_P4D_FREE
> diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
> index 69de47c7ef3c5..a96d4b440f3da 100644
> --- a/include/asm-generic/tlb.h
> +++ b/include/asm-generic/tlb.h
> @@ -213,8 +213,7 @@ static inline void __tlb_remove_table(void *table)
> {
> struct ptdesc *ptdesc = (struct ptdesc *)table;
>
> - pagetable_dtor(ptdesc);
> - pagetable_free(ptdesc);
> + pagetable_dtor_free(ptdesc);
> }
> #endif
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index cad11fa10c192..94078c488e904 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -3001,6 +3001,12 @@ static inline void pagetable_dtor(struct ptdesc *ptdesc)
> lruvec_stat_sub_folio(folio, NR_PAGETABLE);
> }
>
> +static inline void pagetable_dtor_free(struct ptdesc *ptdesc)
> +{
> + pagetable_dtor(ptdesc);
> + pagetable_free(ptdesc);
> +}
> +
> static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc)
> {
> struct folio *folio = ptdesc_folio(ptdesc);
For s390:
Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>
Thanks!
next prev parent reply other threads:[~2025-01-07 14:23 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 9:07 [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table() Qi Zheng
2024-12-30 9:07 ` [PATCH v4 01/15] Revert "mm: pgtable: make ptlock be freed by RCU" Qi Zheng
2024-12-30 9:07 ` [PATCH v4 02/15] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one Qi Zheng
2025-01-06 11:20 ` Alexandre Ghiti
2024-12-30 9:07 ` [PATCH v4 03/15] asm-generic: pgalloc: Provide generic p4d_{alloc_one,free} Qi Zheng
2024-12-30 9:07 ` [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table Qi Zheng
2025-01-02 16:53 ` Kevin Brodsky
2025-01-03 3:53 ` Qi Zheng
2025-01-03 7:46 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 05/15] arm64: pgtable: use mmu gather to free p4d " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 06/15] s390: pgtable: add statistics for PUD and P4D " Qi Zheng
2025-01-06 10:32 ` Alexander Gordeev
2025-01-06 11:05 ` Qi Zheng
2025-01-06 13:34 ` Alexander Gordeev
2025-01-06 13:37 ` Qi Zheng
2024-12-30 9:07 ` [PATCH v4 07/15] mm: pgtable: introduce pagetable_dtor() Qi Zheng
2025-01-06 10:34 ` Alexander Gordeev
2025-01-06 10:55 ` Qi Zheng
2025-01-06 12:36 ` Alexander Gordeev
2025-01-06 13:23 ` Qi Zheng
2025-01-07 9:23 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 08/15] arm: pgtable: move pagetable_dtor() to __tlb_remove_table() Qi Zheng
2024-12-30 9:07 ` [PATCH v4 09/15] arm64: " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 10/15] riscv: " Qi Zheng
2025-01-02 16:53 ` Kevin Brodsky
2025-01-03 3:48 ` Qi Zheng
2025-01-03 8:02 ` Kevin Brodsky
2025-01-03 9:13 ` Qi Zheng
2025-01-03 9:35 ` Qi Zheng
2025-01-03 13:27 ` Kevin Brodsky
2025-01-06 3:49 ` Qi Zheng
2025-01-07 9:57 ` Kevin Brodsky
2025-01-07 10:51 ` Qi Zheng
2025-01-07 11:58 ` Kevin Brodsky
2025-01-07 12:31 ` Qi Zheng
2025-01-07 14:17 ` Kevin Brodsky
2024-12-30 9:07 ` [PATCH v4 11/15] x86: " Qi Zheng
2024-12-30 9:07 ` [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD " Qi Zheng
2025-01-06 10:36 ` Alexander Gordeev
2025-01-06 11:02 ` Qi Zheng
2025-01-06 12:44 ` Alexander Gordeev
2025-01-06 13:34 ` Qi Zheng
2025-01-06 14:35 ` Alexander Gordeev
2025-01-06 14:44 ` Qi Zheng
2024-12-30 9:07 ` [PATCH v4 13/15] mm: pgtable: introduce generic __tlb_remove_table() Qi Zheng
2025-01-07 12:32 ` Andreas Larsson
2025-01-07 12:34 ` Qi Zheng
2025-01-07 14:20 ` Alexander Gordeev
2024-12-30 9:07 ` [PATCH v4 14/15] mm: pgtable: move __tlb_remove_table_one() in x86 to generic file Qi Zheng
2024-12-30 9:07 ` [PATCH v4 15/15] mm: pgtable: introduce generic pagetable_dtor_free() Qi Zheng
2025-01-07 14:22 ` Alexander Gordeev [this message]
2024-12-31 0:24 ` [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table() Andrew Morton
2025-01-02 17:00 ` Kevin Brodsky
2025-01-03 3:56 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z304l1Y6DHosXlBh@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=muchun.song@linux.dev \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yuzhao@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).