From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Paul Barker <paul.barker.ct@bp.renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Thierry Bultel <thierry.bultel.yh@bp.renesas.com>,
thierry.bultel@linatsea.fr, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Ulrich Hecht <uli@fpond.eu>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v4 08/13] serial: sh-sci: Introduced function pointers
Date: Tue, 18 Mar 2025 22:45:05 +0100 [thread overview]
Message-ID: <Z9npYaRwzhsoLxS9@shikoro> (raw)
In-Reply-To: <999cb080-ea61-45e5-9ea0-356fb8bc4639@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Hi Paul,
> We discussed both approaches internally and did an initial
> proof-of-concept of a separate driver. The result was over 1,000 lines
> of code copy-pasted from the existing sh-sci driver into the new driver,
> which is generally something maintainers want us to avoid doing.
Darn, 1000 lines of logic is a lot...
> trade off here is whether we want a single more complex driver, or two
> copies of much of the code so that bugfixes/improvements to the common
> sections in the future need to be duplicated.
Exactly.
> The RZ/V2H and RZ/G3E have interfaces of both the existing sh-sci
> register layout ("SCIF" ports in RZ/V2H & RZ/G3E manual) and the RZ/T2H
> style register layout ("RSCI" ports in RZ/V2H manual, "SCI" ports in
> RZ/G3E manual), so keeping things closely aligned as we move forward
> will be beneficial. I expect that this will be easier with a combined
> driver.
I will have a look at the series.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-03-18 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250306152451.2356762-1-thierry.bultel.yh@bp.renesas.com>
[not found] ` <20250306152451.2356762-9-thierry.bultel.yh@bp.renesas.com>
2025-03-14 11:05 ` [PATCH v4 08/13] serial: sh-sci: Introduced function pointers Geert Uytterhoeven
2025-03-17 9:55 ` Wolfram Sang
2025-03-17 10:27 ` Paul Barker
2025-03-18 21:45 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9npYaRwzhsoLxS9@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=thierry.bultel@linatsea.fr \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).