From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Oreoluwa Babatunde <quic_obabatun@quicinc.com>,
ysato@users.sourceforge.jp, dalias@libc.org
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3] sh: Restructure setup code to reserve memory regions earlier
Date: Thu, 11 Jul 2024 12:26:21 +0200 [thread overview]
Message-ID: <aea743f7f514cfea239ece0fe8f697b9a8acc09f.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20240520175802.2002183-1-quic_obabatun@quicinc.com>
Hi Oreoluwa,
On Mon, 2024-05-20 at 10:58 -0700, Oreoluwa Babatunde wrote:
> The unflatten_device_tree() function contains a call to
> memblock_alloc(). This is a problem because this allocation is done
> before any of the reserved memory regions are set aside in
> paging_init().
> As a result, there is a possibility for memblock to unknowingly allocate
> from any of the memory regions that are meant to be reserved.
>
> Hence, restructure the setup code to set aside reserved memory
> regions before any allocations are done using memblock.
Let me test this first to see whether this causes any regressions on my
J2 board. Afterwards, I will review and merge the patch to my SH tree.
Sorry for taking so long for this.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2024-07-11 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 17:58 [PATCH v3] sh: Restructure setup code to reserve memory regions earlier Oreoluwa Babatunde
2024-07-11 10:26 ` John Paul Adrian Glaubitz [this message]
2024-07-11 11:07 ` John Paul Adrian Glaubitz
2024-07-11 21:50 ` Oreoluwa Babatunde
2024-07-12 9:44 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aea743f7f514cfea239ece0fe8f697b9a8acc09f.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=kernel@quicinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=quic_obabatun@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).