From: yukaixiong <yukaixiong@huawei.com>
To: Paul Moore <paul@paul-moore.com>
Cc: <akpm@linux-foundation.org>, <mcgrof@kernel.org>,
<ysato@users.sourceforge.jp>, <dalias@libc.org>,
<glaubitz@physik.fu-berlin.de>, <luto@kernel.org>,
<tglx@linutronix.de>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <hpa@zytor.com>,
<viro@zeniv.linux.org.uk>, <brauner@kernel.org>, <jack@suse.cz>,
<kees@kernel.org>, <j.granados@samsung.com>,
<willy@infradead.org>, <Liam.Howlett@oracle.com>,
<vbabka@suse.cz>, <lorenzo.stoakes@oracle.com>,
<trondmy@kernel.org>, <anna@kernel.org>, <chuck.lever@oracle.com>,
<jlayton@kernel.org>, <neilb@suse.de>, <okorniev@redhat.com>,
<Dai.Ngo@oracle.com>, <tom@talpey.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<jmorris@namei.org>, <linux-sh@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-nfs@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-security-module@vger.kernel.org>,
<wangkefeng.wang@huawei.com>
Subject: Re: [PATCH -next 07/15] security: min_addr: move sysctl into its own file
Date: Tue, 27 Aug 2024 09:38:21 +0800 [thread overview]
Message-ID: <aeb685e9-3a2d-13b4-4ec8-0752ded06d61@huawei.com> (raw)
In-Reply-To: <CAHC9VhS=5k3zZyuuon2c6Lsf5GixAra6+d3A4bG2FVytv33n_w@mail.gmail.com>
On 2024/8/27 6:49, Paul Moore wrote:
> On Mon, Aug 26, 2024 at 8:05 AM Kaixiong Yu <yukaixiong@huawei.com> wrote:
>> The dac_mmap_min_addr belongs to min_addr.c, move it into
>> its own file from /kernel/sysctl.c. In the previous Linux kernel
>> boot process, sysctl_init_bases needs to be executed before
>> init_mmap_min_addr, So, register_sysctl_init should be executed
>> before update_mmap_min_addr in init_mmap_min_addr.
>>
>> Signed-off-by: Kaixiong Yu <yukaixiong@huawei.com>
>> ---
>> kernel/sysctl.c | 9 ---------
>> security/min_addr.c | 11 +++++++++++
>> 2 files changed, 11 insertions(+), 9 deletions(-)
>>
>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>> index 41d4afc978e6..0c0bab3dad7d 100644
>> --- a/kernel/sysctl.c
>> +++ b/kernel/sysctl.c
>> @@ -2059,15 +2059,6 @@ static struct ctl_table vm_table[] = {
>> .proc_handler = proc_dointvec_minmax,
>> .extra1 = SYSCTL_ZERO,
>> },
>> -#ifdef CONFIG_MMU
>> - {
>> - .procname = "mmap_min_addr",
>> - .data = &dac_mmap_min_addr,
>> - .maxlen = sizeof(unsigned long),
>> - .mode = 0644,
>> - .proc_handler = mmap_min_addr_handler,
>> - },
>> -#endif
>> #if (defined(CONFIG_X86_32) && !defined(CONFIG_UML))|| \
>> (defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL))
>> {
>> diff --git a/security/min_addr.c b/security/min_addr.c
>> index 0ce267c041ab..b2f61649e110 100644
>> --- a/security/min_addr.c
>> +++ b/security/min_addr.c
>> @@ -44,8 +44,19 @@ int mmap_min_addr_handler(const struct ctl_table *table, int write,
>> return ret;
>> }
>>
>> +static struct ctl_table min_addr_sysctl_table[] = {
>> + {
>> + .procname = "mmap_min_addr",
>> + .data = &dac_mmap_min_addr,
>> + .maxlen = sizeof(unsigned long),
>> + .mode = 0644,
>> + .proc_handler = mmap_min_addr_handler,
>> + },
>> +};
> I haven't chased all of the Kconfig deps to see if there is a problem,
> but please provide a quick explanation in the commit description about
> why it is okay to drop the CONFIG_MMU check.
According to the compilation condition in security/Makefile:
obj-$(CONFIG_MMU) += min_addr.o
if CONFIG_MMU is not defined, min_addr.c would not be included in the
compilation process.
So，it is okay to drop the CONFIG_MMU check.
>> static int __init init_mmap_min_addr(void)
>> {
>> + register_sysctl_init("vm", min_addr_sysctl_table);
>> update_mmap_min_addr();
>>
>> return 0;
>> --
>> 2.25.1
next prev parent reply other threads:[~2024-08-27 1:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240826120559eucas1p1a1517b9f4dbeeae893fd2fa770b47232@eucas1p1.samsung.com>
2024-08-26 12:04 ` [PATCH -next 00/15] sysctl: move sysctls from vm_table into its own files Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 01/15] mm: vmstat: move sysctls to " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 02/15] mm: filemap: move sysctl to its own file Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 03/15] mm: swap: " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 04/15] mm: vmscan: move vmscan sysctls " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 05/15] mm: util: move sysctls into it own files Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 06/15] mm: mmap: move sysctl into its own file Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 07/15] security: min_addr: " Kaixiong Yu
2024-08-26 22:49 ` Paul Moore
2024-08-27 1:38 ` yukaixiong [this message]
2024-08-27 1:56 ` Paul Moore
2024-08-27 2:43 ` yukaixiong
2024-08-26 12:04 ` [PATCH -next 08/15] mm: nommu: move sysctl to " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 09/15] fs: fs-writeback: " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 10/15] fs: drop_caches: " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 11/15] sunrpc: use vfs_pressure_ratio() helper Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 12/15] fs: dcache: move the sysctl into its own file Kaixiong Yu
2024-08-26 19:56 ` Kees Cook
2024-09-02 11:04 ` Jan Kara
2024-09-02 11:17 ` Christian Brauner
2024-08-26 12:04 ` [PATCH -next 13/15] x86: vdso: " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 14/15] sh: " Kaixiong Yu
2024-08-26 12:04 ` [PATCH -next 15/15] sysctl: remove unneeded include Kaixiong Yu
2024-08-26 19:57 ` [PATCH -next 00/15] sysctl: move sysctls from vm_table into its own files Kees Cook
2024-08-27 2:03 ` yukaixiong
2024-09-02 7:17 ` Joel Granados
2024-09-02 10:55 ` yukaixiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb685e9-3a2d-13b4-4ec8-0752ded06d61@huawei.com \
--to=yukaixiong@huawei.com \
--cc=Dai.Ngo@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hpa@zytor.com \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=jmorris@namei.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=tglx@linutronix.de \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).