From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: Use plain struct copy in early_console_setup()
Date: Tue, 3 Dec 2024 18:45:44 +0200 [thread overview]
Message-ID: <b71bb27e-003f-4b5d-8654-c7639b105e29@tuxon.dev> (raw)
In-Reply-To: <e097e5c11afe5bd4c01135779c9a40e707ef6374.1733243287.git.geert+renesas@glider.be>
Hi, Geert,
On 03.12.2024 18:30, Geert Uytterhoeven wrote:
> Using memcpy() prevents the compiler from doing any checking on the
> types of the passed pointer parameters. Copy the structure using struct
> assignment instead, to increase type-safety.
>
> No change in generated code on all relevant architectures
> (arm/arm64/riscv/sh).
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Not sure, do you think it should carry a fixes tag?
> ---
> drivers/tty/serial/sh-sci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index df523c7444230836..1ed13ce2c2952547 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3542,7 +3542,7 @@ static int __init early_console_setup(struct earlycon_device *device,
> return -ENODEV;
>
> device->port.type = type;
> - memcpy(&sci_ports[0].port, &device->port, sizeof(struct uart_port));
> + sci_ports[0].port = device->port;
I'm currently preparing my fixes around this code. I think I should rebase
on top of your patch :)
Thank you,
Claudiu
> port_cfg.type = type;
> sci_ports[0].cfg = &port_cfg;
> sci_ports[0].params = sci_probe_regmap(&port_cfg);
next prev parent reply other threads:[~2024-12-03 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 16:30 [PATCH] serial: sh-sci: Use plain struct copy in early_console_setup() Geert Uytterhoeven
2024-12-03 16:45 ` Claudiu Beznea [this message]
2024-12-03 16:49 ` Claudiu Beznea
2024-12-03 17:01 ` Geert Uytterhoeven
2024-12-04 11:28 ` Lad, Prabhakar
2024-12-04 16:12 ` Claudiu Beznea
2025-01-30 8:33 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71bb27e-003f-4b5d-8654-c7639b105e29@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).