From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons
Date: Thu, 11 Sep 2025 13:39:58 +0200 [thread overview]
Message-ID: <bccfde5bca138b8f3489f517ea62168ec4658336.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <kqtaw37b6upcuorurnccs6gqvp2aj33afanxnqye7txkmr5be6@k2omfqynjscv>
Hi Dmitry,
On Mon, 2025-09-08 at 05:27 -0700, Dmitry Torokhov wrote:
> On Wed, Aug 13, 2025 at 03:50:09PM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 11, 2025 at 03:44:57PM -0700, Dmitry Torokhov wrote:
> > > Convert the board to use static device properties instead of platform
> > > data to describe LEDs and GPIO-connected buttons on the board, so
> > > that support for platform data can be removed from gpio-keys and other
> > > drivers, unifying their behavior.
> >
> > ...
> >
> > > --- a/arch/sh/boards/mach-rsk/devices-rsk7203.c
> > > +++ b/arch/sh/boards/mach-rsk/devices-rsk7203.c
> >
> > > #include <linux/gpio.h>
> >
> > Do we still need this one?
>
> Yes, at least this one still uses gpio_request() for configuring some
> GPIOs, so we need to keep it at least for now.
>
> >
> > Ditto for the rest similar cases.
>
> I'll review them to make sure they are still needed.
OK, I'll look forward to your second version of the patch. I might pick it
up for v6.18 provided that we'll manage to squeeze it in in time.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2025-09-11 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 22:44 [PATCH] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons Dmitry Torokhov
2025-08-13 12:50 ` Andy Shevchenko
2025-09-08 12:27 ` Dmitry Torokhov
2025-09-11 11:39 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bccfde5bca138b8f3489f517ea62168ec4658336.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=dalias@libc.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).