From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
ysato@users.sourceforge.jp, dalias@libc.org, lee@kernel.org,
danielt@kernel.org, simona.vetter@ffwll.ch
Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel test robot <lkp@intel.com>,
Jingoo Han <jingoohan1@gmail.com>,
Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH] arch: sh: Include <linux/io.h> in dac.h
Date: Tue, 28 Oct 2025 18:12:26 +0100 [thread overview]
Message-ID: <d2fc41710dcf9bac245303b51d0cdc7ea2186910.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20251028170913.16711-1-tzimmermann@suse.de>
Hi Thomas,
On Tue, 2025-10-28 at 18:07 +0100, Thomas Zimmermann wrote:
> Include <linux/io.h> to avoid depending on <linux/backlight.h> for
> including it. Declares __raw_readb() and __raw_writeb().
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510282206.wI0HrqcK-lkp@intel.com/
> Fixes: 243ce64b2b37 ("backlight: Do not include <linux/fb.h> in header file")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Daniel Thompson (RISCstar) <danielt@kernel.org>
> Cc: Simona Vetter <simona.vetter@ffwll.ch>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Daniel Thompson <danielt@kernel.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> This is fallout from a recent cleanup of the backlight header file. I don't
> have the option of building or testing this change, though.
> ---
> arch/sh/include/cpu-sh3/cpu/dac.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sh/include/cpu-sh3/cpu/dac.h b/arch/sh/include/cpu-sh3/cpu/dac.h
> index fd02331608a8..323ec8570bcd 100644
> --- a/arch/sh/include/cpu-sh3/cpu/dac.h
> +++ b/arch/sh/include/cpu-sh3/cpu/dac.h
> @@ -2,6 +2,8 @@
> #ifndef __ASM_CPU_SH3_DAC_H
> #define __ASM_CPU_SH3_DAC_H
>
> +#include <linux/io.h>
> +
> /*
> * Copyright (C) 2003 Andriy Skulysh
> */
I'll perform a test build tomorrow. And I think I should be able to test it on my
HP Jornada 680 which is based on a SH-3 CPU.
CC'ing Artur Rojek who's got the same model and previously worked on the SH-3 code.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2025-10-28 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 17:07 [PATCH] arch: sh: Include <linux/io.h> in dac.h Thomas Zimmermann
2025-10-28 17:12 ` John Paul Adrian Glaubitz [this message]
2025-10-30 11:20 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2fc41710dcf9bac245303b51d0cdc7ea2186910.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=contact@artur-rojek.eu \
--cc=dalias@libc.org \
--cc=danielt@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).