From: "Looi, Hong Aun" <hong.aun.looi@intel.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Shahab Vahedi <Shahab.Vahedi@synopsys.com>,
"Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "Voon, Weifeng" <weifeng.voon@intel.com>,
"Lai, Peter Jun Ann" <peter.jun.ann.lai@intel.com>,
"Zulkifli,
Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>,
"Tan, Tee Min" <tee.min.tan@intel.com>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: RE: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy
Date: Wed, 5 Apr 2023 13:03:53 +0000 [thread overview]
Message-ID: <DM4PR11MB54545199C99137AE8498B56EBE909@DM4PR11MB5454.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ef0b7276-0fd3-4517-de59-c76e6a57d192@samsung.com>
> On 05.04.2023 12:07, Shahab Vahedi wrote:
> > On 4/5/23 11:39, Michael Sit Wei Hong wrote:
> >> Some DT devices already have phy device configured in the DT/ACPI.
> >> Current implementation scans for a phy unconditionally even though
> >> there is a phy listed in the DT/ACPI and already attached.
> >>
> >> We should check the fwnode if there is any phy device listed in
> >> fwnode and decide whether to scan for a phy to attach to.y
> >>
> >> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> >> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a
> >> PHY")
> >> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
> >> ---
> > Works fine on ARC HSDK board.
> > Tested-by: Shahab Vahedi <shahab@synopsys.com>
>
> Tested-by: Marek Szyprowski
>
> Works fine on Khadas VIM3, Odroid-C4 and Odroid-M1.
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
Please fix the minor typo at the end of your commit message.
Regards,
Hong Aun
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2023-04-05 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230405093945.3549491-1-michael.wei.hong.sit@intel.com>
2023-04-05 10:07 ` [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy Shahab Vahedi
2023-04-05 10:10 ` Shahab Vahedi
2023-04-05 10:53 ` Marek Szyprowski
2023-04-05 13:03 ` Looi, Hong Aun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB54545199C99137AE8498B56EBE909@DM4PR11MB5454.namprd11.prod.outlook.com \
--to=hong.aun.looi@intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Shahab.Vahedi@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=peter.jun.ann.lai@intel.com \
--cc=tee.min.tan@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).