* [PATCH] ALSA: core: fix unit test dependencies
@ 2024-02-04 21:21 Arnd Bergmann
2024-02-05 7:08 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-02-04 21:21 UTC (permalink / raw
To: Jaroslav Kysela, Takashi Iwai, Ivan Orlov
Cc: Arnd Bergmann, linux-sound, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The Kunit tests fail to link when PCM support is disabled:
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'
Add the appropriate dependencies.
Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/core/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..9a44f259ccca 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI
config SND_CORE_TEST
tristate "Sound core KUnit test"
depends on KUNIT
+ depends on SND_PCM
default KUNIT_ALL_TESTS
help
This options enables the sound core functions KUnit test.
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: core: fix unit test dependencies
2024-02-04 21:21 [PATCH] ALSA: core: fix unit test dependencies Arnd Bergmann
@ 2024-02-05 7:08 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-02-05 7:08 UTC (permalink / raw
To: Arnd Bergmann
Cc: Jaroslav Kysela, Takashi Iwai, Ivan Orlov, Arnd Bergmann,
linux-sound, linux-kernel
On Sun, 04 Feb 2024 22:21:29 +0100,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The Kunit tests fail to link when PCM support is disabled:
>
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
> sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
> sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
> sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
> aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
> sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
> aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'
>
> Add the appropriate dependencies.
>
> Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, but this was already fixed on for-next branch.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-05 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 21:21 [PATCH] ALSA: core: fix unit test dependencies Arnd Bergmann
2024-02-05 7:08 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).