From: Daniel Gomez <da.gomez@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>, Kees Cook <kees@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Rusty Russell" <rusty@rustcorp.com.au>,
"Petr Pavlu" <petr.pavlu@suse.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
linux-modules@vger.kernel.org,
"Hans Verkuil" <hverkuil+cisco@kernel.org>,
"Malcolm Priestley" <tvboxspy@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-hardening@vger.kernel.org,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Chris Li" <sparse@chrisli.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH v2 3/3] module: Add compile-time check for embedded NUL characters
Date: Fri, 19 Dec 2025 13:41:00 +0100 [thread overview]
Message-ID: <07d04170-921e-4692-8d3e-d01859d66828@kernel.org> (raw)
In-Reply-To: <47a2f0c7-c25f-4734-840b-fdefc2f3c4a9@kernel.org>
On 19/12/2025 13.29, Matthieu Baerts wrote:
> $ touch net/mptcp/crypto_test.c && make C=1 net/mptcp/crypto_test.o
> CC [M] net/mptcp/crypto_test.o
> CHECK net/mptcp/crypto_test.c
> net/mptcp/crypto_test.c:72:1: error: bad integer constant expression
> net/mptcp/crypto_test.c:72:1: error: static assertion failed: "MODULE_INFO(license, ...) contains embedded NUL byte"
> net/mptcp/crypto_test.c:73:1: error: bad integer constant expression
> net/mptcp/crypto_test.c:73:1: error: static assertion failed: "MODULE_INFO(description, ...) contains embedded NUL byte"
>
FYI, we were discussing the fix here:
https://lore.kernel.org/all/20251211175101.GA3405942@google.com/
Sami provided a fix to the thread that you can test. It'd be good to know if it
works for you too. But we still have some questions as we are not familiar with
the sparse code.
Sami, would you mind sending a patch to the sparse list and then we can ask
questions there?
next prev parent reply other threads:[~2025-12-19 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251010030348.it.784-kees@kernel.org>
[not found] ` <68ed624c.050a0220.3ba739.64ea@mx.google.com>
[not found] ` <D1CBCBE2-3A54-410A-B15C-F1C621F9F56B@kernel.org>
[not found] ` <CANiDSCu6xZAuSF5_M-4BMRc52hbSh_1QfDQqaeGR4iD5fdQjQg@mail.gmail.com>
[not found] ` <202510141344.E0ABCD2C7@keescook>
[not found] ` <CANiDSCsBAq3Yx4ybarUb_1NkQ-bvfXvWqb-DfqXatkiYJFZWiQ@mail.gmail.com>
[not found] ` <202510201127.D97BCF2@keescook>
[not found] ` <CANiDSCtbrM4Fg_p56EdV09ts_j8HnMCc1hGH31-BZvv03Z0DjQ@mail.gmail.com>
[not found] ` <202510201146.F12EA92@keescook>
2025-11-11 13:14 ` [v2,0/3] module: Add compile-time check for embedded NUL characters Daniel Gomez
[not found] ` <20251010030610.3032147-3-kees@kernel.org>
2025-12-19 12:29 ` [PATCH v2 3/3] " Matthieu Baerts
2025-12-19 12:41 ` Daniel Gomez [this message]
2025-12-19 12:44 ` Dan Carpenter
2025-12-19 14:59 ` Matthieu Baerts
2026-01-16 23:35 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07d04170-921e-4692-8d3e-d01859d66828@kernel.org \
--to=da.gomez@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rusty@rustcorp.com.au \
--cc=samitolvanen@google.com \
--cc=sparse@chrisli.org \
--cc=tvboxspy@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).