From: Kees Cook <kees@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Philipp Reisner <philipp.reisner@linbit.com>
Cc: Kees Cook <kees@kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compiler.h: Fix undefined BUILD_BUG_ON_ZERO()
Date: Sat, 16 Nov 2024 21:26:33 -0800 [thread overview]
Message-ID: <173182119158.650820.5112435274770871325.b4-ty@kernel.org> (raw)
In-Reply-To: <20241115204602.249590-1-philipp.reisner@linbit.com>
On Fri, 15 Nov 2024 21:46:02 +0100, Philipp Reisner wrote:
> <linux/compiler.h> defines __must_be_array() and __must_be_cstr() and
> both expand to BUILD_BUG_ON_ZERO(), but <linux/build_bug.h> defines
> BUILD_BUG_ON_ZERO(). Including <linux/build_bug.h> in
> <linux/compiler.h> would create a cyclic dependency as
> <linux/build_bug.h> already includes <linux/compiler.h>.
>
> Fix that by defining __BUILD_BUG_ON_ZERO_MSG() in <linux/compiler.h>
> and using that for __must_be_array() and __must_be_cstr().
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] compiler.h: Fix undefined BUILD_BUG_ON_ZERO()
https://git.kernel.org/kees/c/d7a516c6eeae
Take care,
--
Kees Cook
prev parent reply other threads:[~2024-11-17 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 10:14 [PATCH 0/1] Add missing include in compiler.h Philipp Reisner
2024-11-14 10:14 ` [PATCH 1/1] compiler.h: Add missing include statement for build_bug.h Philipp Reisner
2024-11-14 10:40 ` Dan Carpenter
2024-11-14 11:01 ` Philipp Reisner
2024-11-14 11:05 ` Dan Carpenter
2024-11-14 17:42 ` Linus Torvalds
2024-11-14 18:28 ` Linus Torvalds
2024-11-14 18:40 ` Linus Torvalds
2024-11-15 20:46 ` [PATCH] compiler.h: Fix undefined BUILD_BUG_ON_ZERO() Philipp Reisner
2024-11-15 20:48 ` Kees Cook
2024-11-15 21:58 ` Linus Torvalds
2024-11-15 21:57 ` Linus Torvalds
2024-11-17 5:26 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173182119158.650820.5112435274770871325.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=philipp.reisner@linbit.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).