* Re: [PATCH net] net: add inline annotation to fix the build warning
[not found] ` <CAAjsZQxkH8nmHchtFFPm5VouLEaViR5HTRCCnrP0d9jSF2pGAQ@mail.gmail.com>
@ 2024-10-03 16:11 ` Edward Cree
2024-10-03 18:39 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Edward Cree @ 2024-10-03 16:11 UTC (permalink / raw)
To: Moon Yeounsu, Eric Dumazet
Cc: davem, kuba, pabeni, linux, j.granados, judyhsiao, James.Z.Li,
netdev, linux-kernel, Simon Horman, linux-sparse
On 03/10/2024 16:33, Moon Yeounsu wrote:
> On 03/10/2024 15:19, Eric Dumazet wrote:
>> It also does not know about conditional locking, it is quite useless.
> So... What do you think about who wants to send the patch to silence
> the Sparse's warning message, nevertheless?
Fwiw, my experience is that if I can't explain the locking to sparse
that's usually a sign that the code is too complex and needs to be
rewritten.
In general I'm in favour of patches to fix sparse warnings. In this
case it looks like what's needed is __cond_acquires, but the patch
to implement that in sparse[1] doesn't seem to have gotten anywhere
near Luc's tree. (Yet it's present and occasionally used in the
kernel...) CCing the sparse ML to find out why.
-ed
[1]: https://lore.kernel.org/all/CAHk-=wjZfO9hGqJ2_hGQG3U_XzSh9_XaXze=HgPdvJbgrvASfA@mail.gmail.com/#t
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: add inline annotation to fix the build warning
2024-10-03 16:11 ` [PATCH net] net: add inline annotation to fix the build warning Edward Cree
@ 2024-10-03 18:39 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2024-10-03 18:39 UTC (permalink / raw)
To: Edward Cree
Cc: Moon Yeounsu, Eric Dumazet, davem, kuba, pabeni, linux,
j.granados, judyhsiao, James.Z.Li, netdev, linux-kernel,
Simon Horman, linux-sparse
On Thu, 3 Oct 2024 17:11:26 +0100
Edward Cree <ecree.xilinx@gmail.com> wrote:
> On 03/10/2024 16:33, Moon Yeounsu wrote:
> > On 03/10/2024 15:19, Eric Dumazet wrote:
> >> It also does not know about conditional locking, it is quite useless.
> > So... What do you think about who wants to send the patch to silence
> > the Sparse's warning message, nevertheless?
In my experience, conditional locking is often a cause of bugs.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-03 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241001193352.151102-1-yyyynoom@gmail.com>
[not found] ` <CAAjsZQx1NFdx8HyBmDqDxQbUvcxbaag5y-ft+feWLgQeb1Qfdw@mail.gmail.com>
[not found] ` <CANn89i+aHZWGqWjCQXacRV4SBGXJvyEVeNcZb7LA0rCwifQH2w@mail.gmail.com>
[not found] ` <CAAjsZQxEKLZd-fQdRiu68uX6Kg4opW4wsQRaLcKyfnQ+UyO+vw@mail.gmail.com>
[not found] ` <CANn89i+hNfRjhvpRR+WXqD72ko4_-N+Tj3CqmJTBGyi3SpQ+Og@mail.gmail.com>
[not found] ` <CAAjsZQxkH8nmHchtFFPm5VouLEaViR5HTRCCnrP0d9jSF2pGAQ@mail.gmail.com>
2024-10-03 16:11 ` [PATCH net] net: add inline annotation to fix the build warning Edward Cree
2024-10-03 18:39 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).