From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>,
Chris Li <sparse@chrisli.org>,
linux-sparse@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: make xfs sparse-warning free
Date: Fri, 14 Nov 2025 06:52:22 +0100 [thread overview]
Message-ID: <20251114055249.1517520-1-hch@lst.de> (raw)
Hi all,
this series isn't really a series, but a collection of two very different
patches toward the result of having no sparse warnings for fs/xfs/.
Patch 1 adds a cond_lock annotation to the lockref code. This also fixes
warnings (but resurfaces new ones) in erofs and gfs2.
Patch 2 moves some XFS code around to help the lock context tracking.
I actually think this improves the code, so I think this should go into
the XFS tree.
Patch 3 duplicates some XFS code to work around the lock context tracking,
but I think it is pretty silly. Maybe it's a good example to help improve
this code in sparse? It would not be horrible to apply given how little
code it duplicates, but a fix in sparse would be much nicer.
The kernel MAINTAINERS still list Luc as sparse maintainer, but sparse
itself lists Chris again. Do we need to update the kernel MAINTAINERS
file, or are those separate roles?
next reply other threads:[~2025-11-14 5:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 5:52 Christoph Hellwig [this message]
2025-11-14 5:52 ` [PATCH 1/3] lockref: add a __cond_lock annotation for lockref_put_or_lock Christoph Hellwig
2025-11-14 18:18 ` Linus Torvalds
2025-11-18 5:58 ` Christoph Hellwig
2025-11-14 5:52 ` [PATCH 2/3] xfs: move some code out of xfs_iget_recycle Christoph Hellwig
2025-11-14 17:04 ` Darrick J. Wong
2025-11-14 17:28 ` Linus Torvalds
2025-11-18 5:59 ` Christoph Hellwig
2025-11-14 5:52 ` [PATCH 3/3] xfs: work around sparse context tracking in xfs_qm_dquot_isolate Christoph Hellwig
2025-11-14 17:06 ` Darrick J. Wong
2025-11-18 6:00 ` Christoph Hellwig
2025-11-14 17:56 ` make xfs sparse-warning free Linus Torvalds
2025-11-18 5:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114055249.1517520-1-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=cem@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).