From: Nicolas Schier <nicolas@fjasle.eu>
To: Vincent Mailhol <mailhol@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org,
linux-hardening@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative()
Date: Thu, 1 Jan 2026 20:39:46 +0100 [thread overview]
Message-ID: <20260101-futuristic-petrel-of-ecstasy-23db5f@lindesnes> (raw)
In-Reply-To: <acdd84b2-e893-419c-8a46-da55d695dda2@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]
On Thu, Jan 01, 2026 at 04:10:36PM +0100, Vincent Mailhol wrote:
> On 20/12/2025 at 12:02, Vincent Mailhol wrote:
> > The is_non_negative() and is_negative() function-like macros just
> > exist as a workaround to silence the -Wtype-limits warning. Now that
> > this warning is disabled, those two macros have lost their raison
> > d'être. Remove them.
> >
> > This reverts commit dc7fe518b049 ("overflow: Fix -Wtype-limits
> > compilation warnings").
> >
> > Suggested-by: Nicolas Schier <nsc@kernel.org>
> > Link: https://lore.kernel.org/all/aUT_yWin_xslnOFh@derry.ads.avm.de
> > Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
>
> So at the end, this patch got five kernel test robot reports:
>
> https://lore.kernel.org/all/202512221735.mRV4BZqB-lkp@intel.com/
> https://lore.kernel.org/all/202512230342.Lgha2HGH-lkp@intel.com/
> https://lore.kernel.org/all/202512251340.UApIFw9R-lkp@intel.com/
> https://lore.kernel.org/all/202512271618.33YepxDC-lkp@intel.com/
> https://lore.kernel.org/all/202512280906.wt7UNpya-lkp@intel.com/
>
> All these are the same smatch warning just triggered from a different
> place. I think it is still too early to undo that workaround in
> include/linux/overflow.h, otherwise developers would be getting that
> smatch report too often.
>
> I will send a v4 in which I will drop this patch. This basically means
> that the v4 is a revert to v1...
thanks! I think it's a bit sad to keep code only to make some checker
tooling happy, but for now it seems to be the right thing to do.
Kind Regards,
Nicolas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-01-01 20:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 11:02 [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 1/3] " Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 2/3] kbuild: cleanup local -Wno-type-limits exceptions Vincent Mailhol
2025-12-20 12:53 ` Nicolas Schier
2025-12-20 11:02 ` [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative() Vincent Mailhol
2025-12-20 12:52 ` Nicolas Schier
2025-12-22 10:03 ` kernel test robot
2025-12-22 18:39 ` Vincent Mailhol
2025-12-22 19:55 ` kernel test robot
2025-12-25 6:04 ` kernel test robot
2025-12-27 8:49 ` kernel test robot
2025-12-28 1:41 ` kernel test robot
2026-01-01 15:10 ` Vincent Mailhol
2026-01-01 19:39 ` Nicolas Schier [this message]
2026-01-02 11:04 ` Miguel Ojeda
2026-01-02 22:26 ` Vincent Mailhol
2026-01-02 22:29 ` [PATCH] overflow: Update is_non_negative() and is_negative() comment Vincent Mailhol
2026-01-03 10:02 ` Dan Carpenter
2026-01-03 11:10 ` Vincent Mailhol
2026-01-03 16:56 ` Dan Carpenter
2026-01-03 19:40 ` Vincent Mailhol
2026-01-05 7:26 ` Dan Carpenter
2026-01-05 23:56 ` [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260101-futuristic-petrel-of-ecstasy-23db5f@lindesnes \
--to=nicolas@fjasle.eu \
--cc=airlied@gmail.com \
--cc=clm@fb.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mailhol@kernel.org \
--cc=morbo@google.com \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
--cc=simona@ffwll.ch \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).