From: Chris Li <sparse@chrisli.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-sparse@vger.kernel.org,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH RESEND2 1/4] parse: initial parsing of __attribute__((format))
Date: Fri, 16 Jan 2026 16:14:50 -0800 [thread overview]
Message-ID: <CACePvbWpTrKpFXLr4=vkVpDqhU7wd=RMOy4Wm1gAKhVtEv9=wQ@mail.gmail.com> (raw)
In-Reply-To: <11df30dc-e1d9-4f40-a9ac-43cb1af69da0@codethink.co.uk>
On Mon, Dec 22, 2025 at 3:49 AM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> On 01/12/2025 19:23, Chris Li wrote:
> > Hi Ben,
> >
> > Thanks for the patch and sorry for the late reply.
> >
> > Your format attribute series work applies to the sparse-dev tree fine
> > and "make check" runs fine as well. Thank you so much.
> >
> > I have some trivial coding style of feedback for you, see the comments
> > below. Mostly just nitpicks, does not impact the coding behavior. Let
> > me know if you want to update a new series or I can be lazy and just
> > apply your current series.
>
> Thank you. I've implemented most of your parse.c/symbol.h changes now.
Great.
>
> I am not actually back at work until 2nd-Jan 2026 so may not get
> all the other changes sorted.
>
No problem. I just started catching up on my backlogs from the holiday.
Chris
next prev parent reply other threads:[~2026-01-17 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 15:39 Add printf/scanf -Wformat checking Ben Dooks
2025-10-20 15:39 ` [PATCH RESEND2 1/4] parse: initial parsing of __attribute__((format)) Ben Dooks
2025-12-01 19:23 ` Chris Li
2025-12-22 11:49 ` Ben Dooks
2026-01-17 0:14 ` Chris Li [this message]
2025-10-20 15:39 ` [PATCH RESEND2 2/4] add -Wformat Ben Dooks
2025-10-20 15:39 ` [PATCH RESEND2 3/4] evaluate: check variadic argument types against formatting info Ben Dooks
2025-12-01 19:52 ` Chris Li
2025-10-20 15:39 ` [PATCH RESEND2 4/4] tests: add varargs printf format tests Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACePvbWpTrKpFXLr4=vkVpDqhU7wd=RMOy4Wm1gAKhVtEv9=wQ@mail.gmail.com' \
--to=sparse@chrisli.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).