From: Vincent Mailhol <mailhol@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Nicolas Schier <nicolas@fjasle.eu>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org,
linux-hardening@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative()
Date: Fri, 2 Jan 2026 23:26:35 +0100 [thread overview]
Message-ID: <b549e430-5623-4c60-acb1-4b5e095ae870@kernel.org> (raw)
In-Reply-To: <CANiq72=jRT+6+2PBgshsK-TpxPiRK70H-+3D6sYaN-fdfC83qw@mail.gmail.com>
On 02/01/2026 at 12:04, Miguel Ojeda wrote:
> On Thu, Jan 1, 2026 at 9:13 PM Nicolas Schier <nicolas@fjasle.eu> wrote:
>>
>> thanks! I think it's a bit sad to keep code only to make some checker
>> tooling happy, but for now it seems to be the right thing to do.
>
> Perhaps a patch to add a comment explaining Vincent's findings would
> be a good outcome, i.e. explaining the reason it needs to remain in
> place for the moment
OK. But I will send this as a separate patch as a reply to this thread
so that this can be discussed separately without having to respin the
main series again and again. I will add it back to the main series only
if it get a decent level of Acked-by tags.
> (even a link to lore.kernel.org to this thread would help).
It is rather uncommon to add lore.kernel.org links in the code comment.
But I am not against. I will do as you suggested so and see what people
think of it.
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2026-01-02 22:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 11:02 [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 1/3] " Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 2/3] kbuild: cleanup local -Wno-type-limits exceptions Vincent Mailhol
2025-12-20 12:53 ` Nicolas Schier
2025-12-20 11:02 ` [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative() Vincent Mailhol
2025-12-20 12:52 ` Nicolas Schier
2025-12-22 10:03 ` kernel test robot
2025-12-22 18:39 ` Vincent Mailhol
2025-12-22 19:55 ` kernel test robot
2025-12-25 6:04 ` kernel test robot
2025-12-27 8:49 ` kernel test robot
2025-12-28 1:41 ` kernel test robot
2026-01-01 15:10 ` Vincent Mailhol
2026-01-01 19:39 ` Nicolas Schier
2026-01-02 11:04 ` Miguel Ojeda
2026-01-02 22:26 ` Vincent Mailhol [this message]
2026-01-02 22:29 ` [PATCH] overflow: Update is_non_negative() and is_negative() comment Vincent Mailhol
2026-01-03 10:02 ` Dan Carpenter
2026-01-03 11:10 ` Vincent Mailhol
2026-01-03 16:56 ` Dan Carpenter
2026-01-03 19:40 ` Vincent Mailhol
2026-01-05 7:26 ` Dan Carpenter
2026-01-05 23:56 ` [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b549e430-5623-4c60-acb1-4b5e095ae870@kernel.org \
--to=mailhol@kernel.org \
--cc=airlied@gmail.com \
--cc=clm@fb.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=morbo@google.com \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas@fjasle.eu \
--cc=nsc@kernel.org \
--cc=simona@ffwll.ch \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).