From: Mark Brown <broonie@kernel.org>
To: Mans Rullgard <mans@mansr.com>
Cc: David Jander <david@protonic.nl>, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: fix null pointer dereference within spi_sync
Date: Wed, 01 May 2024 22:47:49 +0900 [thread overview]
Message-ID: <171457126983.1892571.15279588004472260364.b4-ty@kernel.org> (raw)
In-Reply-To: <20240430182705.13019-1-mans@mansr.com>
On Tue, 30 Apr 2024 19:27:05 +0100, Mans Rullgard wrote:
> If spi_sync() is called with the non-empty queue and the same spi_message
> is then reused, the complete callback for the message remains set while
> the context is cleared, leading to a null pointer dereference when the
> callback is invoked from spi_finalize_current_message().
>
> With function inlining disabled, the call stack might look like this:
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: fix null pointer dereference within spi_sync
commit: 4756fa529b2f12b7cb8f21fe229b0f6f47190829
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2024-05-01 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 18:27 [PATCH] spi: fix null pointer dereference within spi_sync Mans Rullgard
2024-05-01 6:24 ` David Jander
2024-05-01 13:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171457126983.1892571.15279588004472260364.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=david@protonic.nl \
--cc=linux-spi@vger.kernel.org \
--cc=mans@mansr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).