From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Russell King <linux@armlinux.org.uk>
Subject: [PATCH v3 9/9] spi: pxa2xx: Don't provide struct chip_data for others
Date: Wed, 17 Apr 2024 13:54:36 +0300 [thread overview]
Message-ID: <20240417110334.2671228-10-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240417110334.2671228-1-andriy.shevchenko@linux.intel.com>
Now the struct chip_data is local to spi-pxa2xx.c, move
its definition to the C file. This will slightly speed up
a build and also hide badly named data type (too generic).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-pxa2xx.c | 8 ++++++++
drivers/spi/spi-pxa2xx.h | 8 --------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 030afb17e606..efe76d0c21bb 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -66,6 +66,14 @@ MODULE_ALIAS("platform:pxa2xx-spi");
| CE4100_SSCR1_RFT | CE4100_SSCR1_TFT | SSCR1_MWDS \
| SSCR1_SPH | SSCR1_SPO | SSCR1_LBM)
+struct chip_data {
+ u32 cr1;
+ u32 dds_rate;
+ u32 threshold;
+ u16 lpss_rx_threshold;
+ u16 lpss_tx_threshold;
+};
+
#define LPSS_GENERAL_REG_RXTO_HOLDOFF_DISABLE BIT(24)
#define LPSS_CS_CONTROL_SW_MODE BIT(0)
#define LPSS_CS_CONTROL_CS_HIGH BIT(1)
diff --git a/drivers/spi/spi-pxa2xx.h b/drivers/spi/spi-pxa2xx.h
index 5f741bb30240..93e1e471e1c6 100644
--- a/drivers/spi/spi-pxa2xx.h
+++ b/drivers/spi/spi-pxa2xx.h
@@ -75,14 +75,6 @@ struct driver_data {
struct gpio_desc *gpiod_ready;
};
-struct chip_data {
- u32 cr1;
- u32 dds_rate;
- u32 threshold;
- u16 lpss_rx_threshold;
- u16 lpss_tx_threshold;
-};
-
static inline u32 pxa2xx_spi_read(const struct driver_data *drv_data, u32 reg)
{
return pxa_ssp_read_reg(drv_data->ssp, reg);
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-04-17 11:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 10:54 [PATCH v3 0/9] spi: pxa2xx: Drop linux/spi/pxa2xx_spi.h Andy Shevchenko
2024-04-17 10:54 ` [PATCH v3 1/9] spi: pxa2xx: Allow number of chip select pins to be read from property Andy Shevchenko
2024-05-02 8:06 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 2/9] spi: pxa2xx: Provide num-cs for Sharp PDAs via device properties Andy Shevchenko
2024-05-02 8:07 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 3/9] spi: pxa2xx: Move contents of linux/spi/pxa2xx_spi.h to a local one Andy Shevchenko
2024-05-02 8:09 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 4/9] spi: pxa2xx: Remove outdated documentation Andy Shevchenko
2024-05-02 8:09 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 5/9] spi: pxa2xx: Don't use "proxy" headers Andy Shevchenko
2024-05-02 8:10 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 6/9] spi: pxa2xx: Drop struct pxa2xx_spi_chip Andy Shevchenko
2024-05-02 8:10 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 7/9] spi: pxa2xx: Remove DMA parameters from struct chip_data Andy Shevchenko
2024-05-02 8:11 ` Linus Walleij
2024-04-17 10:54 ` [PATCH v3 8/9] spi: pxa2xx: Remove timeout field " Andy Shevchenko
2024-05-02 8:11 ` Linus Walleij
2024-04-17 10:54 ` Andy Shevchenko [this message]
2024-05-02 8:12 ` [PATCH v3 9/9] spi: pxa2xx: Don't provide struct chip_data for others Linus Walleij
2024-04-25 11:40 ` [PATCH v3 0/9] spi: pxa2xx: Drop linux/spi/pxa2xx_spi.h Andy Shevchenko
2024-05-01 14:18 ` Mark Brown
2024-05-06 14:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417110334.2671228-10-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).