From: Rob Herring <robh@kernel.org>
To: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Michal Simek <michal.simek@amd.com>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Eng Lee Teh <englee.teh@starfivetech.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset control
Date: Wed, 24 Apr 2024 15:11:05 -0500 [thread overview]
Message-ID: <20240424201105.GA428137-robh@kernel.org> (raw)
In-Reply-To: <20240424051317.2084059-3-jisheng.teoh@starfivetech.com>
On Wed, Apr 24, 2024 at 01:13:17PM +0800, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
>
> Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com>
> Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
3 people developed 4 lines of code? Generally the first S-o-b should be
the author (.i.e. a From line).
> ---
> Documentation/devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index d4b61b0e8301..2358489be4bc 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -55,6 +55,11 @@ properties:
> label:
> description: Descriptive name of the SPI controller.
>
> + resets:
> + description: |
> + Optional entry to specify the reset controller to the SPI
Drop the description.
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.43.2
>
prev parent reply other threads:[~2024-04-24 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 5:13 [PATCH v1 0/2] Add optional reset control for Cadence SPI Ji Sheng Teoh
2024-04-24 5:13 ` [PATCH v1 1/2] spi: spi-cadence: Add optional reset control support Ji Sheng Teoh
2024-04-24 16:26 ` kernel test robot
2024-04-24 18:40 ` kernel test robot
2024-04-25 1:54 ` Lars-Peter Clausen
2024-04-24 5:13 ` [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset control Ji Sheng Teoh
2024-04-24 20:11 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424201105.GA428137-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=englee.teh@starfivetech.com \
--cc=jisheng.teoh@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).