From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
lorenzo.bianconi83@gmail.com,
linux-arm-kernel@lists.infradead.org, upstream@airoha.com
Subject: Re: [PATCH] spi: airoha: initialize as_ctrl at pointer declaration
Date: Fri, 3 May 2024 22:34:28 +0300 [thread overview]
Message-ID: <CAHp75VdkjMrUTWGxzeFkzVi8LUTD7npL5RLon8BXjt8dzWPAfw@mail.gmail.com> (raw)
In-Reply-To: <580665ed95340031d0d42d1a4a16f7fcd5d150d7.1714755642.git.lorenzo@kernel.org>
On Fri, May 3, 2024 at 8:03 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> This patch introduces just two cosmetic changes to airoha spi-nand driver:
"Introduce just..."
> - move airoha_snand_ids definition after airoha_snand_probe routine
airoha_snand_probe()
> - always initialize airoha_snand_ctrl pointer similar to
> airoha_snand_dev one
With split to two (Mark might ask you to split these to two) or as a single one,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-05-03 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 17:03 [PATCH] spi: airoha: initialize as_ctrl at pointer declaration Lorenzo Bianconi
2024-05-03 19:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdkjMrUTWGxzeFkzVi8LUTD7npL5RLon8BXjt8dzWPAfw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).